Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1949633 - Review Request: python-pick - pick an option in the terminal with a simple GUI
Summary: Review Request: python-pick - pick an option in the terminal with a simple GUI
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Karolina Surma
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2021-04-14 17:28 UTC by gerry
Modified: 2021-04-21 13:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
ksurma: fedora-review+


Attachments (Terms of Use)

Description gerry 2021-04-14 17:28:49 UTC
Spec URL: https://raw.githubusercontent.com/Nycticoraci/FriendlyFedora/main/python-pick/python-pick.spec
SRPM URL: https://raw.githubusercontent.com/Nycticoraci/FriendlyFedora/main/python-pick/python-pick-1.0.0-1.fc35.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=65807735
Description: pick is a small python library to help you create curses based interactive selection list in the terminal.
Fedora Account System Username: gbechard

This is my first package, looking for sponsor.

Comment 1 Karolina Surma 2021-04-16 09:15:26 UTC
Hi, 

I have a few comments regarding the package.
- The most important issue is build requiring python3dist(nose) as a test runner. nose is deprecated and it must not be pulled by the new packages.
You could ask the upstream to replace it or use a different test runner for this package (for details see: https://fedoraproject.org/wiki/Changes/DeprecateNose)

- Also please note that no tests were actually run in the %check section.

See relevant part of the build.log:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Uxucbx
+ umask 022
+ cd /builddir/build/BUILD
+ cd pick-1.0.0
+ /usr/bin/python3 setup.py test
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
(...)
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s


- The rpmlint warning should be fixed.




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable


Issues:
=======
- Package must not depend on deprecated() packages.
  Note: python3-nose is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Expat License", "Unknown or generated", "*No copyright* Expat
     License". 4 files have unknown license. Detailed output of
     licensecheck in /home/ksurma/tmp/1949633-python-pick/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-pick-1.0.0-1.fc35.noarch.rpm
          python-pick-1.0.0-1.fc35.src.rpm
python3-pick.noarch: W: summary-not-capitalized C pick an option in the terminal with a simple GUI
python-pick.src: W: summary-not-capitalized C pick an option in the terminal with a simple GUI
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
python3-pick.noarch: W: summary-not-capitalized C pick an option in the terminal with a simple GUI
1 packages and 0 specfiles checked; 0 errors, 1 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pick/pick-1.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 03f13d4f5bfe74db4b969fb74c0ef110ec443978419d6c0f1f375a0d49539034
  CHECKSUM(SHA256) upstream package : 03f13d4f5bfe74db4b969fb74c0ef110ec443978419d6c0f1f375a0d49539034


Requires
--------
python3-pick (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-pick:
    python-pick
    python3-pick
    python3.9-pick
    python3.9dist(pick)
    python3dist(pick)

Comment 2 gerry 2021-04-19 18:25:01 UTC
Spec URL: https://raw.githubusercontent.com/Nycticoraci/FriendlyFedora/main/python-pick/python-pick.spec
SRPM URL: https://raw.githubusercontent.com/Nycticoraci/FriendlyFedora/main/python-pick/python-pick-1.0.0-2.fc35.src.rpm

Replaced nose BuildRequires with pytest; package pulls from GitHub release containing tests. Fixed rpmlint warnings.

Comment 3 Karolina Surma 2021-04-21 13:16:12 UTC
Looks good to me.

Small nitpicks (which don't prevent package approval):
- When you use macro in URL, it's a bit more complicated to get to the source code. It'd be better to be able to copy&paste the URL directly.
- The address in Source0 is valid but you may be interested in a more readable way to write it:
https://github.com/wong2/%{pypi_name}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz


Package APPROVED. 
Please note you still need a sponsor to proceed.


Note You need to log in before you can comment on or make changes to this bug.