Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1951440 - libunity: FTBFS in Fedora rawhide
Summary: libunity: FTBFS in Fedora rawhide
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libunity
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL: https://koschei.fedoraproject.org/pac...
Whiteboard: AcceptedFreezeException
: 1968831 2003590 (view as bug list)
Depends On: 2003599
Blocks: PYTHON3.10 F35BetaFreezeException F35FTBFS F35FailsToInstall F36FTBFS
TreeView+ depends on / blocked
 
Reported: 2021-04-20 07:05 UTC by Tomáš Hrnčiar
Modified: 2021-09-18 00:42 UTC (History)
5 users (show)

Fixed In Version: libunity-7.1.4-27.20190319.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-18 00:42:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2021-04-20 07:05:14 UTC
Description of problem:
Package libunity fails to build from source in Fedora rawhide.

Version-Release number of selected component (if applicable):
7.1.4-24.20190319.fc34

Steps to Reproduce:
koji build --scratch f35 libunity-7.1.4-24.20190319.fc34.src.rpm

Additional info:
This package is tracked by Koschei. See:
https://koschei.fedoraproject.org/package/libunity

Comment 1 Rex Dieter 2021-04-29 20:52:47 UTC
Appears to be a vala issue (specific to rawhide),

protocol-icon.vala:188.3-188.27: error: overriding method `Unity.Protocol.AnnotatedIcon.serialize' is incompatible with base method `GLib.Variant? GLib.Icon.serialize ()': Base method expected return type `GLib.Variant?', but `GLib.Variant' was provided.
  private Variant serialize ()

Comment 2 Miro Hrončok 2021-06-04 20:13:50 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 3 Miro Hrončok 2021-06-07 22:58:33 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 4 Miro Hrončok 2021-06-08 11:16:43 UTC
*** Bug 1968831 has been marked as a duplicate of this bug. ***

Comment 5 Miro Hrončok 2021-07-26 09:12:01 UTC
Seems like this wass still an issue durng the mass rebuild. I'd like to help, but since this is not a Python issue, I have no idea how.

Note that pytohn3-libunity fails to install.

Comment 6 Ben Cotton 2021-08-10 12:59:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 7 Miro Hrončok 2021-08-24 20:25:24 UTC
(In reply to Rex Dieter from comment #1)
> Appears to be a vala issue (specific to rawhide),
> 
> protocol-icon.vala:188.3-188.27: error: overriding method
> `Unity.Protocol.AnnotatedIcon.serialize' is incompatible with base method
> `GLib.Variant? GLib.Icon.serialize ()': Base method expected return type
> `GLib.Variant?', but `GLib.Variant' was provided.
>   private Variant serialize ()

Hey Rex. Any chance you will have time to fix/workaround this before F35 beta?

Comment 8 Miro Hrončok 2021-09-09 18:22:11 UTC
Friendly reminder. Could you please have a look a this soon?

Comment 9 Miro Hrončok 2021-09-13 09:42:00 UTC
*** Bug 2003590 has been marked as a duplicate of this bug. ***

Comment 10 Mamoru TASAKA 2021-09-13 13:29:49 UTC
Note that I just tried obeying what vala errors say, and at least I managed to fix FTBFS:

F-36 https://koji.fedoraproject.org/koji/taskinfo?taskID=75603713
F-35 https://koji.fedoraproject.org/koji/taskinfo?taskID=75603725

For Non-responsive maintainer, I will leave judgment to other people.

Comment 11 Miro Hrončok 2021-09-13 15:56:38 UTC
Rex, can we push Mamoru's fix?

Comment 12 Timothée Ravier 2021-09-13 17:37:38 UTC
@Mamoru Thanks! Could you submit that as a PR?

Comment 13 Rex Dieter 2021-09-13 22:56:45 UTC
Any fixes would be greatly appreciated

Comment 14 Mamoru TASAKA 2021-09-13 22:57:46 UTC
PR submitted: https://src.fedoraproject.org/rpms/libunity/pull-request/1

Comment 15 Mamoru TASAKA 2021-09-14 01:07:33 UTC
* Rex merged the above PR
* F-36 built successfully - https://koji.fedoraproject.org/koji/taskinfo?taskID=75635795
* F-35 is also built: will submit bodhi updates request.

Comment 16 Fedora Update System 2021-09-14 01:08:57 UTC
FEDORA-2021-d02f268e38 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d02f268e38

Comment 17 Fedora Update System 2021-09-14 18:48:40 UTC
FEDORA-2021-d02f268e38 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d02f268e38`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d02f268e38

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Miro Hrončok 2021-09-17 11:05:00 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 36.

Thanks for taking care of it!

Comment 19 Adam Williamson 2021-09-17 22:16:51 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/454 , marking accepted.

Comment 20 Fedora Update System 2021-09-18 00:42:33 UTC
FEDORA-2021-d02f268e38 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.