Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1959035 - Review Request: python-owl_rl - OWL-RL and RDFS based RDF Closure inferencing for Python
Summary: Review Request: python-owl_rl - OWL-RL and RDFS based RDF Closure inferencing...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: fedora-neuro
TreeView+ depends on / blocked
Reported: 2021-05-10 15:37 UTC by Aniket Pradhan
Modified: 2021-06-04 01:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-06-04 01:12:30 UTC
Type: ---
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Aniket Pradhan 2021-05-10 15:37:20 UTC
Spec URL:

Description: odML (open metadata Markup Language) is a file format for storing arbitrary metadata. The underlying data model offers a way to store metadata in a structured human- and machine-readable way. Well organized metadata management is a key component to guarantee reproducibility of experiments and to track provenance of performed analyses.

python-odml is the python library for reading and writing odml metadata files. It is a registered research resource with the RRID:SCR_001376.

Fedora Account System Username: major
Koji Build:

I am using the updated version of the W3C license that upstream is using. They too have updated it on their repository, but is not present in the current release.

Comment 1 Robert-André Mauchin 🐧 2021-05-15 14:08:44 UTC
Source1:        LICENSE.txt

 - I would prefer you grab it from upstream directly:


 - Remove that weird shebang in prep:

python3-owlrl.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/owlrl/ 644 /d/Bin/Python/python.exe 

 - Use the %pytest macro:

%if %{with tests}
# test_version_converter needs an internet connection, therefore disabled
%pytest -k 'not cls_maxqc1' \
    --deselect test/

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 124 files have unknown license.
     Detailed output of licensecheck in /home/bob/packaging/review/python-
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: python3-owlrl-5.2.1-1.fc35.noarch.rpm
python3-owlrl.noarch: W: spelling-error Summary(en_US) inferencing -> conferencing, referencing, inference
python3-owlrl.noarch: W: spelling-error %description -l en_US odML -> Odom
python3-owlrl.noarch: W: spelling-error %description -l en_US reproducibility -> reprehensibility
python3-owlrl.noarch: W: spelling-error %description -l en_US odml -> model
python3-owlrl.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/owlrl/ 644 /d/Bin/Python/python.exe 
python3-owlrl.noarch: W: no-manual-page-for-binary RDFConvertService
python3-owlrl.noarch: W: no-manual-page-for-binary owlrl
python-owl_rl-doc.noarch: W: spelling-error Summary(en_US) inferencing -> conferencing, referencing, inference
python-owl_rl-doc.noarch: W: spelling-error %description -l en_US odML -> Odom
python-owl_rl-doc.noarch: W: spelling-error %description -l en_US reproducibility -> reprehensibility
python-owl_rl-doc.noarch: W: spelling-error %description -l en_US odml -> model
python-owl_rl.src: W: spelling-error Summary(en_US) inferencing -> conferencing, referencing, inference
python-owl_rl.src: W: spelling-error %description -l en_US odML -> Odom
python-owl_rl.src: W: spelling-error %description -l en_US reproducibility -> reprehensibility
python-owl_rl.src: W: spelling-error %description -l en_US odml -> model
3 packages and 0 specfiles checked; 1 errors, 14 warnings.

Comment 2 Aniket Pradhan 2021-05-17 09:55:06 UTC
Hey Robert,

I have done the changes as asked. Thanks for taking up the review :D

Comment 3 Robert-André Mauchin 🐧 2021-05-17 11:47:59 UTC
Package approved.

Comment 4 Gwyn Ciesla 2021-05-24 13:55:30 UTC
(fedscm-admin):  The Pagure repository was created at

Comment 5 Fedora Update System 2021-05-26 11:28:43 UTC
FEDORA-2021-757cd571e5 has been submitted as an update to Fedora 34.

Comment 6 Fedora Update System 2021-05-27 01:32:06 UTC
FEDORA-2021-757cd571e5 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-757cd571e5 \*`
You can provide feedback for this update here:

See also for more information on how to test updates.

Comment 7 Fedora Update System 2021-06-04 01:12:30 UTC
FEDORA-2021-757cd571e5 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.