Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196531 - Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files
Summary: Review Request: perl-MP3-Info - Manipulate / fetch info from MP3 audio files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-06-24 02:53 UTC by Christopher Stone
Modified: 2008-05-31 23:07 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-26 19:47:43 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Stone 2006-06-24 02:53:11 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/perl-MP3-Info.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/perl-MP3-Info-1.20-1.src.rpm

Description:
This module is used for getting info out of and into MP3 files.
Comment 1 Jason Tibbitts 2006-06-26 15:12:51 UTC 
Builds fine in mock and rpmlint is silent.

Note that BuildRequires: perl is not necessary.

I see no blockers; everything looks good.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   ffb3427089a6b5f56e35e5b2ab902d29  MP3-Info-1.20.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(MP3::Info) = 1.20
   perl-MP3-Info = 1.20-1.fc6
  =
   perl >= 0:5.006
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(bytes)
   perl(overload)
   perl(strict)
   perl(vars)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=4, Tests=246,  1 wallclock secs ( 0.23 cusr +  0.08 csys =  0.31 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED
Comment 2 Christopher Stone 2006-06-26 19:47:43 UTC 
Built on devel, will build on FC-4 FC-5 after sync.
Comment 3 Christopher Stone 2008-05-31 17:43:13 UTC 
Package Change Request
======================
Package Name: perl-MP3-Info
New Branches: EL-5
Comment 4 Kevin Fenzi 2008-05-31 23:07:02 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.