Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196601 - Review Request: python-vobject - A python library for manipulating vCard and vCalendar files
Summary: Review Request: python-vobject - A python library for manipulating vCard and...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeffrey C. Ollie
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-06-25 19:56 UTC by James Bowes
Modified: 2013-01-10 09:50 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-28 13:37:09 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description James Bowes 2006-06-25 19:56:41 UTC 
Spec URL: http://www.dangerouslyinc.com/~bowes/fe/vobject.spec
SRPM URL: http://www.dangerouslyinc.com/~bowes/fe/vobject-0.3.0-1.src.rpm
Description: VObject is intended to be a full featured python library for parsing and generating vCard and vCalendar files.
Comment 1 Parag AN(पराग) 2006-06-26 03:18:11 UTC 
Not an official review as I'm not yet sponsored
Mock build for development i386 is suceesfull with some warnings
+ /usr/bin/python setup.py build
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'zip_safe'
  warnings.warn(msg)
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'install_requires'
  warnings.warn(msg)

MUST Items:
     - MUST: rpmlint shows no error on i386
     - MUST: dist tag is present
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package vobject, in the
format vobject.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license
Apache Software License.
      - MUST: The License field in the package vobject.spec file did not match
any file in tarball.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
      - MUST: This package owns all directories that it creates. 
      - MUST: This package did not contain any duplicate files in the %files
listing.
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.txt

      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is correct

What you Need:-
      * You dont need to have 
Requires:       python-abi = %(%{__python} -c "import sys ; print sys.version[:3]")
       as this is only for rpms targetting for FC3 or prior.
       * Add License file in tarball if you can alter the tarball contents.
Comment 2 Jeffrey C. Ollie 2006-06-26 14:11:04 UTC 
The package should probably be named python-vobject as well.
Comment 3 James Bowes 2006-06-26 17:22:02 UTC 
Updated locations:
Spec URL: http://www.dangerouslyinc.com/~bowes/fe/python-vobject.spec
SRPM URL: http://www.dangerouslyinc.com/~bowes/fe/python-vobject-0.3.0-1.src.rpm

Thanks for the feedback, guys!

I've:
* Renamed the package to python-vobject
* Removed the python-abi requires
* Removed the unused python-sitearch macro
* Removed some comments left over from the template

I didn't add in the license file, since the released version does not package it
in the tarball. However, the current sources in svn do have a LICENSE file, so
it should be in the next release.
Comment 4 Jeffrey C. Ollie 2006-06-27 03:25:55 UTC 
APPROVED, based upon the review by Parag AN and the updated package.  For
furture reference, please bump the release each time you update the package.
Comment 5 James Bowes 2006-06-28 13:37:09 UTC 
Thanks for your help, everyone!
Comment 6 James Bowes 2007-05-18 15:29:43 UTC 
Package Change Request
======================
Package Name: python-vobject
Updated Fedora Owners: jbowes, dgoodwin
Comment 7 Jens Petersen 2007-05-20 12:30:51 UTC 
done
Comment 8 Dan Horák 2011-05-24 08:20:13 UTC 
Package Change Request
======================
Package Name: python-vobject
New Branches: el6
Owners: sharkcz
Comment 9 Jason Tibbitts 2011-05-24 14:43:04 UTC 
Need an ack here from the Fedora owners.
Comment 10 Dan Horák 2011-05-24 14:57:46 UTC 
Hm, I got no response on email sent 2 weeks ago ... Let's wait a bit if James shows here.
Comment 11 Jens Petersen 2011-05-31 06:56:32 UTC 
Can you please set fedora-cvs flag again when you are ready?
Comment 12 James Bowes 2011-06-06 13:43:06 UTC 
ACK. sorry.
Comment 13 Gwyn Ciesla 2011-06-06 15:45:32 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.