Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 196617 - Review Request: perl-File-chdir - Perl module for local chdir()
Summary: Review Request: perl-File-chdir - Perl module for local chdir()
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 196627
TreeView+ depends on / blocked
Reported: 2006-06-26 01:45 UTC by Ian Burrell
Modified: 2008-06-06 18:58 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-06-29 06:42:58 UTC
Type: ---
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Ian Burrell 2006-06-26 01:45:13 UTC
Spec URL:
Description: a more sensible way to change directories

It is required by the perl-SVN-Mirror which is required by perl-SVK.

Comment 1 Jason Tibbitts 2006-06-26 15:23:21 UTC
I'm not sure why you have "CHECK(GPL or Artistic)" as the license.  "GPL or
Artistic" is correct.  (Perhaps it's cpanspec doing that?)

You should capitalize the summary.

rpmlint complains about these:
W: perl-File-chdir summary-not-capitalized a more sensible way to change directories
W: perl-File-chdir invalid-license CHECK(GPL or Artistic)

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   41a4661789f6de97fb632e4560d37864  File-chdir-0.06.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
X rpmlint is not silent
* final provides and requires are sane:
   perl(File::chdir) = 0.06
   perl-File-chdir = 0.06-1.fc6
   perl >= 0:5.004
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=3, Tests=48,  0 wallclock secs ( 0.08 cusr +  0.04 csys =  0.12 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Jason Tibbitts 2006-06-26 15:24:55 UTC
By the way, it looks like you need to go through and fix the licenses and
perhaps clean up the symmaries of the other spanspec-generated packages you've
submitted.  I'll be happy to review them all but I'll wait for cleaned-up
versions first.

Comment 4 Jason Tibbitts 2006-06-28 17:37:30 UTC
Still builds fine and rpmlint is now quiet.  The issues I had are fixed.


Comment 5 Ian Burrell 2006-06-29 06:42:58 UTC
Added and built for devel.

Comment 6 Ian Burrell 2008-06-06 17:59:35 UTC
Package Change Request
Package Name: perl-File-chdir
New Branches: EL-4 EL-5

Comment 7 Kevin Fenzi 2008-06-06 18:58:42 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.