Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196635 - Review Request: knetworkmanager
Summary: Review Request: knetworkmanager
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-06-26 05:05 UTC by Dennis Gilmore
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-29 11:32:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dennis Gilmore 2006-06-26 05:05:16 UTC
Spec URL: http://ausil.us/packages/knetworkmanager.spec
SRPM URL: http://ausil.us/packages/knetworkmanager-0.1-1svn20060625.fc5.src.rpm
Description: knetworkmanager is a kde frontend for NetworkManager  that integrates with KDE

Comment 1 Rex Dieter 2006-06-26 11:41:25 UTC
Offhand, first thing to fix is to fix Release tag, use instead (something 
like):
Release: 0.1.%{svn}%{?dist}

Is there a reason to use a cvs/svn checkout instead of an official release?  
If so, please document that as a comment in the specfile.  

Also, please document (as comment or whatever) the purpose of of any applied 
patches.

Comment 2 Rex Dieter 2006-06-26 11:42:46 UTC
Nevermind about the "official release" but, it appears there isn't one (yet), 
afaict.

Comment 3 Dennis Gilmore 2006-06-26 14:51:30 UTC
* Mon Jun 27 2006 <dennis> - 0.1-0.1svn20060626
- fix  BuildRequires  missing hal-devel,  fix version to match
- fedora guidelines, add comment about patch  Bad SuSE

SRPM: http://ausil.us/packages/knetworkmanager-0.1-0.1svn20060625.src.rpm
SPEC: http://ausil.us/packages/knetworkmanager.spec

Comment 4 Rex Dieter 2006-06-26 14:55:24 UTC
Need a dot '.' between 0.1 and svn... bits in the Release tag.

Comment 5 Dennis Gilmore 2006-06-26 15:05:01 UTC
* Mon Jun 27 2006 <dennis> - 0.1-0.2.svn20060626
- add a . to the release

SRPM: http://ausil.us/packages/knetworkmanager-0.1-0.2.svn20060625.src.rpm
SPEC: http://ausil.us/packages/knetworkmanager.spec

Comment 6 Rex Dieter 2006-06-26 15:38:33 UTC
As per our IRC chat, patch to use system-config-network instead of (the
hard-coded) yast, and then it's looking pretty good.

Comment 7 Dennis Gilmore 2006-06-26 16:07:55 UTC
* Mon Jun 27 2006 <dennis> - 0.1-0.3.svn20060626
- patch out call to yast and replace with
- system-config-network for dialup

SRPM: http://ausil.us/packages/knetworkmanager-0.1-0.3.svn20060625.src.rpm
SPEC: http://ausil.us/packages/knetworkmanager.spec


Comment 8 Rex Dieter 2006-06-26 16:09:35 UTC
Looks good, APPROVED.

Comment 9 Dennis Gilmore 2006-06-26 21:49:19 UTC
imported  branch requested all built and awaiting push 

Closing 


Note You need to log in before you can comment on or make changes to this bug.