Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1966769 - Drop unnecessary findbugs dependency from libidn
Summary: Drop unnecessary findbugs dependency from libidn
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libidn
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miroslav Lichvar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1964634
TreeView+ depends on / blocked
 
Reported: 2021-06-01 20:25 UTC by Richard Fearn
Modified: 2021-06-02 18:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-02 08:12:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Richard Fearn 2021-06-01 20:25:26 UTC
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1].

libidn currently has this dependency:

  BuildRequires: mvn(com.google.code.findbugs:annotations)

This seems to be because the libidn POM in java/pom.xml.in has this dependency:

      <dependency>
          <groupId>com.google.code.findbugs</groupId>
          <artifactId>annotations</artifactId>
          <version>2.0.1</version>
          <scope>provided</scope>
      </dependency>

That dependency can be downloaded here:

  https://search.maven.org/artifact/com.google.code.findbugs/annotations/2.0.1/jar

It provides classes in these packages:

  * edu.umd.cs.findbugs.annotations
  * javax.annotation (and subpackages)
  * net.jcip.annotations

All these packages contain the word "annotation". I can't see any reference to these packages in the libidn Java code:

  $ fedpkg sources
  
  $ tar -xf libidn-1.37.tar.gz
  
  $ cd libidn-1.37
  
  $ fgrep annotation $(find -name "*.java") | wc -l
  0

I think it's safe to remove the findbugs annotations dependency from libidn.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/

Comment 1 Richard Fearn 2021-06-01 20:27:51 UTC
For reference the findbugs annotation dependency was added to the libidn POM in this commit:

  https://git.savannah.gnu.org/gitweb/?p=libidn.git;a=commitdiff;h=2dfa483b59a8fe890553861ea0b04f594720bccc

Comment 2 Richard Fearn 2021-06-01 20:36:46 UTC
PR: https://src.fedoraproject.org/rpms/libidn/pull-request/3

Comment 3 Miroslav Lichvar 2021-06-02 08:12:40 UTC
Applied, thanks!

Comment 4 Richard Fearn 2021-06-02 18:42:18 UTC
Thanks for the super-quick response!


Note You need to log in before you can comment on or make changes to this bug.