Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1966792 - Drop unnecessary findbugs dependency from ongres-scram
Summary: Drop unnecessary findbugs dependency from ongres-scram
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ongres-scram
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Augusto Caringi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1964634
TreeView+ depends on / blocked
 
Reported: 2021-06-01 21:19 UTC by Richard Fearn
Modified: 2021-06-09 11:13 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-09 07:30:36 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Richard Fearn 2021-06-01 21:19:46 UTC 
FindBugs upstream has been dead since 2016 and I would like to retire it from Fedora [1].

ongres-scram currently has this dependency:

  BuildRequires:  findbugs

This is due to this dependency in the ongres-scram POM:

        <dependency>
            <groupId>com.google.code.findbugs</groupId>
            <artifactId>annotations</artifactId>
            <version>3.0.1</version>
            <scope>provided</scope>
        </dependency>

That dependency can be downloaded here:

  https://search.maven.org/artifact/com.google.code.findbugs/annotations/3.0.1/jar

It provides classes in these packages:

  * edu.umd.cs.findbugs.annotations
  * javax.annotation (and subpackages)
  * net.jcip.annotations

All these packages contain the word "annotation". Searching the ongres-scram source for "annotation", I can only see one usage of the SuppressFBWarnings annotation, in com.ongres.scram.common.message.ServerFinalMessage.

Removing the use of this annotation would allow ongres-scram to build without FindBugs.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YI723NBFFXAOQSRMYIEFAD6CYGX7S6MM/
Comment 1 Richard Fearn 2021-06-01 21:27:11 UTC 
PR: https://src.fedoraproject.org/rpms/ongres-scram/pull-request/2
Comment 2 Pavel Raiskup 2021-06-09 07:30:36 UTC 
THanks Richard, here is the build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69676565
Comment 3 Richard Fearn 2021-06-09 11:13:53 UTC 
Thanks Pavel!
Note You need to log in before you can comment on or make changes to this bug.