Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1967954 - Review Request: ansible-collection-microsoft-sql - The Ansible role to manage Microsoft SQL Server
Summary: Review Request: ansible-collection-microsoft-sql - The Ansible role to manage...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Rich Megginson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2021-06-04 14:09 UTC by Sergei Petrosian
Modified: 2021-06-11 18:48 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
rmeggins: fedora-review+

Attachments (Terms of Use)
spec file (14.27 KB, text/x-matlab)
2021-06-04 14:09 UTC, Sergei Petrosian 		no flags Details
srpm (67.29 KB, application/x-rpm)
2021-06-04 14:10 UTC, Sergei Petrosian 		no flags Details
View All

Description Sergei Petrosian 2021-06-04 14:09:28 UTC 
Created attachment 1788988 [details]
spec file

Created attachment 1788988 [details]
spec file

Spec URL: https://bugzilla.redhat.com/attachment.cgi?id=1788988
SRPM URL: https://bugzilla.redhat.com/attachment.cgi?id=1788989
Description: The package that provides the Ansible role for Microsoft SQL Server management in the collection format within the microsoft.sql collection and in the legacy format in `microsoft/sql-server`.
Fedora Account System Username: spetros
Comment 1 Sergei Petrosian 2021-06-04 14:10:23 UTC 
Created attachment 1788989 [details]
srpm
Comment 2 Sergei Petrosian 2021-06-04 14:14:34 UTC 
Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=69301461 

rpmlint output:

[spetrosi@spetrosi ansible-collection-microsoft-sql]$ fedpkg --release f34 lint
Failed to get repository name from Git url or pushurl
/home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:51: W: macro-in-comment %{archiveurlN}
/home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:267: W: macro-in-comment %files
/home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:270: W: macro-in-comment %dir
/home/spetrosi/Documents/work/sql/ansible-collection-microsoft-sql/ansible-collection-microsoft-sql.spec:287: W: macro-in-comment %doc
ansible-collection-microsoft-sql.src:51: W: macro-in-comment %{archiveurlN}
ansible-collection-microsoft-sql.src:267: W: macro-in-comment %files
ansible-collection-microsoft-sql.src:270: W: macro-in-comment %dir
ansible-collection-microsoft-sql.src:287: W: macro-in-comment %doc
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf
ansible-collection-microsoft-sql-collection-artifact.noarch: W: spelling-error %description -l en_US gz -> g, z, gs
ansible-collection-microsoft-sql-collection-artifact.noarch: E: description-line-too-long C Collection artifact for ansible-collection-microsoft-sql. This package contains microsoft-sql-0.0.1.tar.gz
ansible-collection-microsoft-sql-collection-artifact.noarch: W: no-documentation
3 packages and 1 specfiles checked; 1 errors, 14 warnings.
Could not execute lint: Failed to execute command.
Comment 3 Sergei Petrosian 2021-06-04 14:20:33 UTC 
The PR that compares this spec file to the linux-system-roles spec file. The PR is in my personal Git repo, I use it for convenience to track changes made.
https://github.com/spetrosi/sql/pull/2/files
Comment 4 Sergei Petrosian 2021-06-04 14:28:13 UTC 
Hi Rich, Noriko, Pavel,

Please review the spec file I created for the RPM that will provide the mssql role. I used the linux-system-roles.spec as a base, I removed most unused code from it and only kept what is relevant to mssql. In comment#2, you can find a link to the PR that you can use to view what has been changed in comparison to linux-system-roles.spec.

Thank you
Comment 5 Sergei Petrosian 2021-06-04 14:30:59 UTC 
I think reviewers can comment and suggest changes right on the PR linked in comment#2 instead of doing it here for convenience.
Comment 6 Rich Megginson 2021-06-08 15:43:01 UTC 
Can you address these rpmlint issues?

ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/server/.fmf
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf
ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir /usr/share/microsoft/sql-server/tests/.fmf
ansible-collection-microsoft-sql-collection-artifact.noarch: W: spelling-error %description -l en_US gz -> g, z, gs
ansible-collection-microsoft-sql-collection-artifact.noarch: E: description-line-too-long C Collection artifact for ansible-collection-microsoft-sql. This package contains microsoft-sql-0.0.1.tar.gz
ansible-collection-microsoft-sql-collection-artifact.noarch: W: no-documentation

I think the "W: macro-in-comment" ones are ok.
Comment 7 Sergei Petrosian 2021-06-09 11:46:29 UTC 
(In reply to Rich Megginson from comment #6)
> Can you address these rpmlint issues?
> 
> ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir
> /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/
> server/.fmf
> ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir
> /usr/share/ansible/collections/ansible_collections/microsoft/sql/tests/
> server/.fmf
> ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir
> /usr/share/microsoft/sql-server/tests/.fmf
> ansible-collection-microsoft-sql.noarch: W: hidden-file-or-dir
> /usr/share/microsoft/sql-server/tests/.fmf
Those .fmf directories are required because without them provision.fmf does not work. And provision.fmf is required to provision a VM with more RAM than usual, which is required for mssql installation.

> ansible-collection-microsoft-sql-collection-artifact.noarch: W:
> spelling-error %description -l en_US gz -> g, z, gs
Gvim highlights Ansible as "incorrect" word on this line, I cannot find any other typo on the line so I think this can be ignored too.
> ansible-collection-microsoft-sql-collection-artifact.noarch: E:
> description-line-too-long C Collection artifact for
> ansible-collection-microsoft-sql. This package contains
> microsoft-sql-0.0.1.tar.gz

> ansible-collection-microsoft-sql-collection-artifact.noarch: W:
> no-documentation
These are for the collection_artifact package only meant to be used internally so I think ignoring these two is OK too.

Note that rpmlint does not break the build process and there is no need to mark those warnings as ignored anywhere. The same warning appear on the linux-system-roles spec file too.
Comment 8 Rich Megginson 2021-06-09 15:49:49 UTC 
Ok.  rpmlint looks good.
Comment 9 Sergei Petrosian 2021-06-11 09:17:56 UTC 
You can find the latest spec and SRPM here:
https://spetros.fedorapeople.org/review_ansible-collection-microsoft-sql/
Comment 10 Sergei Petrosian 2021-06-11 16:44:34 UTC 
A request to create the repository for the rpms/ansible-collection-microsoft-sql package:
https://pagure.io/releng/fedora-scm-requests/issue/34576
Comment 11 Sergei Petrosian 2021-06-11 16:55:26 UTC 
A new request to create the repository for the rpms/ansible-collection-microsoft-sql package:
https://pagure.io/releng/fedora-scm-requests/issue/34578

The previous request failed automation because this bug has no assignee so I've assigned myself.
Comment 12 Sergei Petrosian 2021-06-11 18:21:42 UTC 
limb at https://pagure.io/releng/fedora-scm-requests/issue/34578 says the following:
The review is not approved by the assignee of the Bugzilla bug
Hence reassigning the bug to Rich because he approved it already.
Comment 13 Sergei Petrosian 2021-06-11 18:23:44 UTC 
A new request to create the repository for the rpms/ansible-collection-microsoft-sql package:
https://pagure.io/releng/fedora-scm-requests/issue/34589
Comment 14 Gwyn Ciesla 2021-06-11 18:48:47 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-microsoft-sql
Note You need to log in before you can comment on or make changes to this bug.