Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197442 - Review Request: fatsort - sort fat of FAT32/FAT16 on cheap mp3 players
Summary: Review Request: fatsort - sort fat of FAT32/FAT16 on cheap mp3 players
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-01 15:31 UTC by Till Maas
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-24 10:39:23 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Till Maas 2006-07-01 15:31:13 UTC 
Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/fatsort.spec
SRPM URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/fatsort-0.9.6.1-1.src.rpm
Description: Fatsort is a utility written in C to sort FAT16 and FAT32 filesystems. It is needed to sort files on cheap mp3 players that display files not sorted by their name but by their entry in the file allocation table.
Comment 1 Till Maas 2006-07-01 15:39:12 UTC 
I forgot to mention that I this is my first package and I need a sponsor. By 
the way, a review should be very simple, since this is a small package, it 
builds fast in mock and rpmlint does not complain about anything.
Comment 2 Till Maas 2006-07-05 16:19:56 UTC 
Updated Source0 to contain a valid URL:

Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/fatsort.spec
SRPM URL:
http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/fatsort-0.9.6.1-2.src.rpm
Comment 3 Parag AN(पराग) 2006-07-06 09:38:57 UTC 
== Not an official review as I'm not yet sponsored ==
Mock build for development i386 is sucessfull
 
* MUST Items:
     - MUST: rpmlint shows no error 
     - MUST: dist tag is present
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package fatsort, in the
format fatsort.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license GPL.
      - MUST: This Package contains License file as LICENSE.txt
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (ddf8e98b27455da104e8cca13d29d0cc).
      - MUST: This package owns all directories that it creates. 
      - MUST: This package did not contain any duplicate files in the %files
listing.
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.
      - MUST: Package did NOT contained any .la libtool archives.
    
      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is correct
Comment 4 John Mahowald 2006-07-27 02:40:54 UTC 
Builds fine on devel x86_64, anyone have a FAT partition they want to mess up, I
mean, test with this? ;)
Comment 5 Till Maas 2006-07-28 12:54:22 UTC 
Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/fatsort.spec
SRPM URL:
http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/fatsort-0.9.6.1-3.fc5.src.rpm

I use $RPM_OPT_FLAGS instead of %{optflags} now.

Using mount -o loop and mkfs.vfat you can make a FAT partition in an file to
test this.
Comment 6 John Mahowald 2006-08-17 19:51:49 UTC 
Looking good

+ Built on FC5 x86_64
+ Did not harm a vfat partition I tested it with
+ License (GPL)
+ spec readable
+ Name good
+ source matches upstream
+ macro usage
+ file ownership and permissions

APPROVED

I'll sponsor, apply for cvsextras.
Comment 7 Till Maas 2006-08-24 10:39:23 UTC 
Built successfully for devel.
Note You need to log in before you can comment on or make changes to this bug.