Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197981 - Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors
Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Moni...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 197967
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-07 20:07 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-19 21:56:57 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hans de Goede 2006-07-07 20:07:22 UTC 
Spec URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi.spec
SRPM URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi-0.9.12-1.src.rpm
Description:
Plug-in for gkrellm (a system monitor) which monitors the wireless LAN cards in
your PC and displays a graph of the link quality percentage for each card.     

---

Notice please play special attention to the Obsoletes and Provides gkrellm-wireless. Previously this package was (wrongly) integrated into the gkrellm package itself, and there it was called gkrellm-wireless despite upstreams different name, this packages should automaticly replace gkrellm-wireless, hence the Obsoletes & Provides
Comment 1 Hans de Goede 2006-07-07 20:19:05 UTC 
Note 2: I'm going on a short vacation from monday 10 juli till friday 14 juli,
so if I'm quiet thats why.
Comment 2 Ville Skyttä 2006-07-16 20:24:47 UTC 
Blockers:
- Tarball is not upstream one, sha1sums:
  package:  52d13482f7ea71ca0f5613ac5209cbe7d8385f42
  upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507
  There are also substantial differences in their contents.
- Missing dependency on gkrellm.

Other notes/suggestions:

- Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package
  for benefit of folks who rebuild FE packages for example for RHEL.
- A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS
  could be easier to maintain than copy-pasting all flags between Makefile
  and the specfile.
Comment 3 Hans de Goede 2006-07-17 11:58:42 UTC 
(In reply to comment #2)
> Blockers:
> - Tarball is not upstream one, sha1sums:
>   package:  52d13482f7ea71ca0f5613ac5209cbe7d8385f42
>   upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507
>   There are also substantial differences in their contents.

Your right, strange, I took the tarbal straight from the core SRPM, it seems the
 one in core is newer / completer then the upstream one. I've gone back to a
pristine upstream tarbal, with the changes found in the core package in a patch.
I've also mailed upstream for an explanation on the 2 different 0.9.12 versions.

> - Missing dependency on gkrellm.
> - Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package
>   for benefit of folks who rebuild FE packages for example for RHEL.
Both fixed

> - A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS
>   could be easier to maintain than copy-pasting all flags between Makefile
>   and the specfile.

I'm used to doing things like this for non autotooled packages, so I'm keeping
it this way.

New version here:
Spec URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi.spec
SRPM URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi-0.9.12-2.src.rpm

Changes:
* Mon Jul 17 2006 Hans de Goede <j.w.r.degoede> 0.9.12-2
- Use pristine upstream source and put changes found in the Core package
  tarbal in a patch
- Require gkrellm >= 2.2, gkrellm < 3
- Add ExcludeArch: s390 s390x
Comment 4 Ville Skyttä 2006-07-17 19:24:30 UTC 
0.9.12-2 approved.
Comment 5 Hans de Goede 2006-07-19 21:56:57 UTC 
Thanks!

Imported and build, closing.
Comment 6 Hans de Goede 2006-08-09 19:18:22 UTC 
For the record here is the reply I got from upstream about the 2 different versions:
---

Hi,

On Mon, Jul 17, 2006 at 02:07:09PM +0200, Hans de Goede wrote:
> > The one in the core package seems to be newer. I've attached a patch
> > which upgrades the version on your website to this newer version, and
> > thus shows the differences.
> > 
> > Do you know how this is possible?

That's very odd indeed - I have no idea how it happened. However, I
don't use Linux nor GKrellM anymore since I've switched to FreeBSD, so
I wont be making any updates to the sources. You're free to take over
maintaining the plug-in if you'd like.

Regards,
Brix
-- Henrik Brix Andersen <henrik>
Note You need to log in before you can comment on or make changes to this bug.