Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 198013 - Review Request: perl-POE-Component-Child
Summary: Review Request: perl-POE-Component-Child
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-07-08 01:06 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-07-09 19:03:33 UTC
Type: ---

Attachments (Terms of Use)

Description Chris Weyl 2006-07-08 01:06:23 UTC
Spec URL:

This POE component serves as a wrapper for POE::Wheel::Run, obviating
the need to create a session to receive the events it dishes out.

Comment 1 Ralf Corsepius 2006-07-08 01:41:24 UTC
Trying to access the URL above gives:

Page URL Not Found!!

The requested page does not exist on this server. The URL you typed or followed
is either outdated or inaccurate.

Comment 2 Chris Weyl 2006-07-08 01:49:22 UTC
My bad; fixed.

Comment 3 Jason Tibbitts 2006-07-08 04:19:02 UTC
This package seems to be under the GPL only.
The version in your changelog entry is a bit odd ("-0"), causing rpmlint
  W: perl-POE-Component-Child incoherent-version-in-changelog -0 1.39-0.fc6

* source files match upstream:
   35827260ad62e9d1bcbf74ada943deb9  POE-Component-Child-1.39.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is not required)
* %clean is present.
* package builds in mock (development, x86_64).
X rpmlint is silent.
* noarch package, so no debuginfo.
* final provides and requires are sane:
   perl(POE::Component::Child) = 1.39
   perl-POE-Component-Child = 1.39-0.fc6
   perl(POE) >= 0.29
* %check is present and all tests pass:
   ok 19 - all tests successful
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 4 Ralf Corsepius 2006-07-08 04:43:13 UTC
package is noarch

=>   OPTIMIZE="%{optflags}"
is unused/superfluous.

=>  This find also is very likely unnecessary:
find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'

Comment 5 Chris Weyl 2006-07-08 22:52:42 UTC
Updated to deal with licensing and version issues.

Spec URL:

Comment 6 Chris Weyl 2006-07-08 22:53:05 UTC
Updated to deal with licensing and version issues.

Spec URL:

Comment 7 Jason Tibbitts 2006-07-09 00:03:02 UTC
The license is now correct.
The version in the changelog entry is now sensible.

The two issues I had are fixed.  The issues Ralf pointed out are not.  I don't
see them as blockers, but I do recommend that you address them as needless cruft
in specfiles should always be cleaned up.

Comment 8 Jason Tibbitts 2006-07-09 00:04:12 UTC
I neglected to add:


Comment 9 Chris Weyl 2006-07-09 19:03:33 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review! :)

Note You need to log in before you can comment on or make changes to this bug.