There is a problem with Version and URL. There is no such version at project
page.   What is on the project page is 3.18.1. So:

Version:       3.8.1
Release:       1%{dist}

should be better; so that it will reflect the upstream version.

Also,the download URL should be:
http://osdn.dl.sourceforge.net/sourceforge/%{name}/%{name}-%{version}.tar.gz

BTW, rpmlint does not report any error.

As mentioned in the initial request, I have raised this before commiting branch
changes to the project source.  After all issues with the spec file (and desktop
file and icons isnall etc) are fixed (apart from the version matching the
upstream version), then I will commit project code and release properly.  I
didnt want to field lots of problems with the project just after releasing a new
version (the SRPM contains the correct tar.gz file).

The Source0 download URL has been fixed, and new spec file and SRPM generated
and are available as per the initial request.

Thanks

Spec URL: http://queeg.dyndns.org/clusterssh/clusterssh.spec
SRPM URL: http://queeg.dyndns.org/clusterssh/clusterssh-3.18.2.10-2.src.rpm

Should have reported the correct SRPM path before for the changes....

Any other stoppers before I commit projects changes?

Thanks

Hi again,

There is an rpmlint warning from srpm:
W: clusterssh strange-permission clusterssh.spec 0600
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.

I think you will need to repackage SRPM after changing the permission of spec file.

Except rebuilding in mock that I did not test, per review guidelines, spec and
srpm looks good. I built it on FC5 and used ;)

Regards, Devrim

Ok, it builds cleanly in mock.

Thanks - I'll double check the perms and then start on project commits.  Should
have the "real" version of the rpm within a few days.

Spec URL: http://queeg.dyndns.org/clusterssh/clusterssh.spec
SRPM URL: http://queeg.dyndns.org/clusterssh/clusterssh-3.19.1-1.src.rpm

This is the real version i would like to put into extras.  There should
(hopefully) be no errors or issues with it at all (famous last words...)

Thanks

  Duncs

Greetings. Here's a review:

OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
578208faf944100a233ae216fa230350  clusterssh-3.19.1.tar.gz
578208faf944100a233ae216fa230350  clusterssh-3.19.1.tar.gz.1
OK - Package compiles and builds on at least one arch.
n/a - Package needs ExcludeArch
OK - BuildRequires correct
n/a - Spec handles locales/find_lang
n/a - Spec has needed ldconfig in post and postun
n/a - Package is relocatable and has a reason to be.
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
n/a - -doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
n/a - Headers/static libs in -devel subpackage.
n/a - .pc files in -devel subpackage.
n/a - .so files in -devel subpackage.
n/a - -devel package Requires: %{name} = %{version}-%{release}
n/a - .la files are removed.
See below - Package is a GUI app and has a .desktop file
OK - Package doesn't own any directories other packages own.
OK - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
OK - Should build in mock. (fc6/i386)
OK - Should function as described.
OK - Should have sane scriptlets.

Issues:

1. The Source0 line doesn't work for me. I guess the osdl mirror
doesn't have a copy of this source.
http://easynews.dl.sourceforge.net/sourceforge/clusterssh/clusterssh-
3.19.1.tar.gz
worked ok for me.

2. You need to run desktop-file-install in %install for your .desktop
file. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

3. Might include the "THANKS" file as a %doc?

4. Why do you have the:
Requires:      perl-Tk perl-X11-Protocol
rpm picks up those requirements just fine without help. You should remove
those Requires unless there is some reason I don't see why they are there. 

A question on point 2 - the "desktop-file-install".  I have included 

Source1: %{name}.desktop

and

%install
desktop-file-install --vendor %{desktop_vendor}                 \
        --dir ${RPM_BUILD_ROOT}%{_datadir}/applications         \
        --add-category X-Fedora                                 \
        %{SOURCE1}

but when i try to build it i get an error "cannot find clusterssh.spec".  It
seems as though it is not looking in the right place to find it.  How should I
specify the Source1:?

Thanks

Odd. Can you upload your current spec and desktop file?

what is %{desktop_vendor} set to?

%{SOURCE1} should be right for Source1. 

I have put 3 files onto

http://queeg.dyndns.org/clusterssh/

clusterssh.spec
clusterssh.desktop
clusterssh.rpmbuild - contains all the output from me trying to run
$ rpmbuild -ta SOURCES/clusterssh-3.19.1.tar.gz 

This process was working until I attempted to add the "desktop-file-install". 
From what I was able to find out, "%(desktop_vendor}" was a more neutral way of
setting the vendor to "fedora", but in the files above it is expliclty set to
"fedora" (which makes no difference).

Thanks

Oh, and in "playing" I have set replaced SOURCE1 with %{name}.desktop, but that
made no difference either.

Created attachment 134287 [details]
Twealked spec file

The attached spec file works for me, both for mock builds of a regular SRPM,
and when inserted into the tarball, using "rpmbuild -ta tarball"

Thanks Paul.

If you will look at Paul's working spec file you can see the issue...
With desktop-file-install it adds the vendor to the filename, so your 
files section needs to change from: 
%{_datadir}/applications/clusterssh.desktop
to
%{_datadir}/applications/fedora-clusterssh.desktop

Thanks for your help

Spec URL: http://queeg.dyndns.org/clusterssh/clusterssh.spec
SRPM URL: http://queeg.dyndns.org/clusterssh/clusterssh-3.19.1-1.src.rpm

All the outstanding issues from comment #8 appear to be fixed, everything looks 
good to me, so this package is APPROVED. 

Don't forget to close this bug with NEXTRELEASE once this package is imported 
and built for devel. 

Ping Duncan. Do you still intend to import and maintain this package? 
It should be all approved and ready to import...

I have every intention of sorting it out.  Time, however, is a little lacking
currently.

  Duncs

Excellent. I just wanted to make sure you didn't miss that it had been 
approved. :) If you require any assistance at all, feel free to drop me a 
email or catch me on irc. 

Have tried to contact the Fedora maintainer with no response:

Initially by email (4 Feb) then through bugzilla: 
https://bugzilla.redhat.com/show_bug.cgi?id=574430

Package Change Request
======================
Package Name: clusterssh
New Branches: EL-5
Owners: tremble

cvs done.

Package Change Request
======================
Package Name: clusterssh
New Branches: epel7
Owners: tremble filiperosset

Git done (by process-git-requests).