Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2000763 - Review Request: wike - Wikipedia Reader for the GNOME Desktop
Summary: Review Request: wike - Wikipedia Reader for the GNOME Desktop
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2021-09-02 20:34 UTC by Gustavo Costa
Modified: 2021-10-21 19:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-10-21 19:50:22 UTC
Type: ---
Embargoed:
jamatos: fedora-review+

Attachments (Terms of Use)

Description Gustavo Costa 2021-09-02 20:34:52 UTC 
Spec URL: https://xfgusta.fedorapeople.org/packages/wike/wike.spec
SRPM URL: https://xfgusta.fedorapeople.org/packages/wike/wike-1.5.4-1.fc34.src.rpm

Description:
Wike is a Wikipedia reader for the GNOME Desktop. Provides access to all the 
content of this online encyclopedia in a native application, with a simpler and 
distraction-free view of articles.

Fedora Account System Username: xfgusta

Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=75012251

Hi. I'm looking for a sponsor, as this is my first package here. I have been learning more about Fedora packaging by reading some other package submissions, doing some preliminary reviews [1][2][3][4], and opening some pull requests [5][6][7][8]. Furthermore, I have a Copr [9] of this package that was published in the Fedora Magazine [10], although both spec files are quite different.

1. https://bugzilla.redhat.com/show_bug.cgi?id=1986844#c1
2. https://bugzilla.redhat.com/show_bug.cgi?id=1980117#c2
3. https://bugzilla.redhat.com/show_bug.cgi?id=1989943#c1
4. https://bugzilla.redhat.com/show_bug.cgi?id=1994095#c1
5. https://src.fedoraproject.org/rpms/dialect/pull-request/1 
6. https://src.fedoraproject.org/rpms/apostrophe/pull-request/1 
7. https://src.fedoraproject.org/rpms/ghex/pull-request/1
8. https://src.fedoraproject.org/rpms/gnote/pull-request/2
9. https://copr.fedorainfracloud.org/coprs/xfgusta/wike/
10. https://fedoramagazine.org/4-cool-new-projects-to-try-in-copr-for-july-2021/
Comment 1 José Matos 2021-09-03 08:17:05 UTC 
I will take the review and sponsor you.

The review will come soon.
Comment 2 Gustavo Costa 2021-09-03 20:59:15 UTC 
Thank you, José, for sponsoring me.
Comment 3 José Matos 2021-09-09 18:51:12 UTC 
Hi Gustavo,
  the spec file is quite simple but I have some doubts about it.

BuildRequires:  libhandy1-devel
Why is this required at build time?



About installation time I suspect that these requirements are dealt by python3-gobject, right?
Requires:       gtk3
Requires:       libhandy1
Requires:       webkit2gtk3
Comment 4 Gustavo Costa 2021-09-10 02:36:28 UTC 
(In reply to José Matos from comment #3)
> Hi Gustavo,
>   the spec file is quite simple but I have some doubts about it.

Hi José. I hope I can clarify your doubts.

> BuildRequires:  libhandy1-devel
> Why is this required at build time?

Actually, libhandy1-devel is not required to build Wike. I found out that only glib2-devel, which is a libhandy's dependency [1], is used. The glib2-devel is used because of the glib-compile-resources utility [2]. I've already updated the spec file changing libhandy1-devel to glib2-devel.

> About installation time I suspect that these requirements are dealt by
> python3-gobject, right?
> Requires:       gtk3
> Requires:       libhandy1
> Requires:       webkit2gtk3

gtk3, libhandy1, and webkit2gtk3 are used with python3-gobject [3][4], but python3-gobject doesn't provide them.

1. dnf repoquery --depends libhandy-devel
2. https://github.com/hugolabe/Wike/blob/aad1b4c96313b160b68e708a183948b04b1ff15b/data/meson.build#L1
3. https://github.com/hugolabe/Wike/blob/master/src/header.py#L23
4. https://github.com/hugolabe/Wike/blob/master/src/view.py#L25
Comment 5 Gustavo Costa 2021-09-10 02:38:57 UTC 
Spec URL: https://xfgusta.fedorapeople.org/packages/wike/wike.spec
SRPM URL: https://xfgusta.fedorapeople.org/packages/wike/wike-1.5.6-1.fc34.src.rpm

- Update to 1.5.6
- Remove BR libhandy1-devel
- Add BR glib2-devel

Scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=75437262
Comment 6 Gustavo Costa 2021-09-23 20:23:22 UTC 
Spec URL: https://xfgusta.fedorapeople.org/packages/wike/wike.spec
SRPM URL: https://xfgusta.fedorapeople.org/packages/wike/wike-1.5.7-1.fc34.src.rpm

- Update to 1.5.7
Comment 7 José Matos 2021-09-27 09:56:30 UTC 
I have sponsored into the packagers group.

I will finish soon the review and then you can import the package.
Comment 8 José Matos 2021-09-27 10:16:06 UTC 
The license is correct and acceptable for Fedora.
fedora-review does have a minor complaint regarding the ownership of /usr/share/gnome-shell/search-providers and /usr/share/gnome-shell/

Here on F35 I have:
# rpm -qf /usr/share/gnome-shell/search-providers
gnome-terminal-3.40.3-1.fc35.x86_64
gnome-photos-40.0-3.fc35.x86_64
gnome-clocks-40.0-2.fc35.x86_64
gnome-contacts-41~beta-1.fc35.x86_64
gnome-shell-41.0-1.fc35.x86_64
gnome-boxes-41.1-1.fc35.x86_64
nautilus-41.0-1.fc35.x86_64
gnome-calendar-41.0-1.fc35.x86_64
gnome-calculator-41.0-1.fc35.x86_64
gnome-weather-41.0-1.fc35.noarch

Since wike can be used without gnome-shell this is a minor issue that can be solved later.

The spec file is simple, well written and correct so the package is approved.
Comment 9 Gwyn Ciesla 2021-09-27 17:59:56 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/wike
Note You need to log in before you can comment on or make changes to this bug.