Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200310 - Review Request: pyicq-t - ICQ transport for Jabber servers
Summary: Review Request: pyicq-t - ICQ transport for Jabber servers
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael Fleming
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-07-26 19:51 UTC by Jeffrey C. Ollie
Modified: 2009-05-27 15:30 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-06 01:11:35 UTC
Type: ---
Embargoed:
j: fedora-cvs+

Attachments (Terms of Use)

Description Jeffrey C. Ollie 2006-07-26 19:51:46 UTC 
Spec URL: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicqt-0.7-1.fc5.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicqt-0.7-1.fc5.src.rpm
Description:

The ICQ Transport provides a gateway which allows Jabber users to
communicate with their contacts on the ICQ network.
Comment 1 Jochen Schmitt 2006-07-27 17:54:20 UTC 
Good:
+ Tar ball match with upstream.
+ Local build works fine.
+ No complaints for source rpm from rpmlint
+ No complaints for binaries rpm from rpmlint.
+ Mock build works fine.


Bad:
- Tar file has the name pyicq-t but the package is called pyicqt.
- when I start /etc/init.d/pyicqtt start, I will got the following message:
/etc/init.d/pyicqt start
Starting ICQ transport:
/usr/lib/python2.4/site-packages/twisted/words/__init__.py:21: UserWarning:
twisted.words will be undergoing a rewrite at some point in the future.
  warnings.warn("twisted.words will be undergoing a rewrite at some point in the
future.")
Comment 2 Jeffrey C. Ollie 2006-07-27 18:52:31 UTC 
(In reply to comment #1)
> Good:
> + Tar ball match with upstream.
> + Local build works fine.
> + No complaints for source rpm from rpmlint
> + No complaints for binaries rpm from rpmlint.
> + Mock build works fine.
> 
> Bad:
> - Tar file has the name pyicq-t but the package is called pyicqt.

I'll change that in the next rev...

> - when I start /etc/init.d/pyicqtt start, I will got the following message:
> /etc/init.d/pyicqt start
> Starting ICQ transport:
> /usr/lib/python2.4/site-packages/twisted/words/__init__.py:21: UserWarning:
> twisted.words will be undergoing a rewrite at some point in the future.
>   warnings.warn("twisted.words will be undergoing a rewrite at some point in the
> future.")

Yeah, I get that too.  Until the pyicq-t authors update their code, I don't know
what can be done, as this message is generated by twisted:

[root@anim01 ~]# python
Python 2.4.3 (#1, Jun 13 2006, 16:41:18)
[GCC 4.0.2 20051125 (Red Hat 4.0.2-8)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import twisted.words
/usr/lib/python2.4/site-packages/twisted/words/__init__.py:21: UserWarning:
twisted.words will be undergoing a rewrite at some point in the future.
  warnings.warn("twisted.words will be undergoing a rewrite at some point in the
future.")
Comment 3 Paul Howarth 2006-07-28 10:08:42 UTC 
Updated twisted packages will be going into FE devel at some point; see Bug
#171543 where you can find some release candidate packages to try.
Comment 4 Jeffrey C. Ollie 2006-07-31 03:19:29 UTC 
Spec: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-2.fc5.spec
SRPM: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-2.fc5.src.rpm

%changelog
* Sun Jul 30 2006 Jeffrey C. Ollie <jeff> - 0.7-2
- Rename to pyicq-t
- Change Group tag
Comment 5 Jochen Schmitt 2006-08-01 18:37:56 UTC 
rpmlint dows complaints the following on the binary rpm:

rpmlint pyicq-t-0.7-2.noarch.rpm
E: pyicq-t obsolete-not-provided pyicqt
W: pyicq-t incoherent-init-script-name pyicqt
Comment 6 Jeffrey C. Ollie 2006-08-03 16:17:24 UTC 
Spec: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-3.fc5.spec
SRPM: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pyicq-t-0.7-3.fc5.src.rpm

%changelog
* Wed Aug  2 2006 Jeffrey C. Ollie <jeff> - 0.7-3
- Rename more stuff to pyicq-t
Comment 7 Jochen Schmitt 2006-08-03 17:37:46 UTC 
I can approve your package.
Comment 8 Jeffrey C. Ollie 2006-08-06 01:11:35 UTC 
Thanks for the review!  Imported and built for devel, branches requested for
FC-4 and FC-5.
Comment 9 Michael Fleming 2009-05-26 23:54:32 UTC 
Package Change Request
======================
Package Name: pyicq-t
New Branches: EL-4 EL-5
Owners: mfleming
Comment 10 Jason Tibbitts 2009-05-27 15:30:55 UTC 
CVS done.
Note You need to log in before you can comment on or make changes to this bug.