Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 202033 - Review Request: deltarpm
Summary: Review Request: deltarpm
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-08-10 14:35 UTC by Mihai Ibanescu
Modified: 2007-12-29 21:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-17 16:28:21 UTC
Type: ---
Embargoed:
tcallawa: fedora-cvs+

Attachments (Terms of Use)

Description Mihai Ibanescu 2006-08-10 14:35:26 UTC 
Spec URL: http://people.redhat.com/misa/rpms/deltarpm/deltarpm.spec
SRPM URL: http://people.redhat.com/misa/rpms/deltarpm/deltarpm-3.3-2.src.rpm
Description: Create deltas between rpms.


A deltarpm contains the difference between an old
and a new version of a rpm, which makes it possible
to recreate the new rpm from the deltarpm and the old
one. You don't have to have a copy of the old rpm,
deltarpms can also work with installed rpms.
Comment 1 Jochen Schmitt 2006-08-10 17:24:38 UTC 
Good:
+ Tar ball matched with upstream.
+ Local Build works fine.
+ Local install works fine.
+ Local uninstall works fine.
+ License is OK.
+ Mock build works fine.

Bad:
- BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Rpmlint on the source rpm complaints:
  W: deltarpm non-standard-group Applications/Utilitie  s
  W: deltarpm setup-not-quiet
- Rpmlint complaints on binary package:
  W: deltarpm non-standard-group Applications/Utilities
Comment 2 Mihai Ibanescu 2006-08-15 19:18:51 UTC 
Do you have any good suggestion on a good group for this to live in? I can see
it in:

Development/Tools
Applications/Archiving (well, maybe not, rpms are not generally for archives)
Aplications/System
Comment 3 Daniel Riek 2006-08-17 13:22:37 UTC 
Even non-standard yum plugins are in System Environment/Base, so I guess this
goes there as well.
Comment 4 Mihai Ibanescu 2006-08-17 14:22:11 UTC 
Suggested changes were incorporated, please have a look (spec file path is the
same).

http://people.redhat.com/misa/rpms/deltarpm/deltarpm-3.3-3.src.rpm
Comment 5 Jochen Schmitt 2006-08-17 16:28:21 UTC 
You don't need to specify gcc as a BR.

So, If you may remove this BR you are APPROVE.
Comment 6 Mihai Ibanescu 2006-08-17 20:34:25 UTC 
Removed, in deltarpm 3.3-4 (I didn't like 3.3-3 anyway)
Comment 7 Adam Jackson 2007-06-05 11:36:44 UTC 
Package Change Request
======================
Package Name: deltarpm
Updated Fedora Owners: jdieter

As current owner, I'm happy to see this go to someone who's actively working on
it instead.
Comment 8 Tom "spot" Callaway 2007-06-05 15:15:05 UTC 
cvs done.
Comment 9 Jonathan Dieter 2007-12-29 09:15:32 UTC 
Package Change Request
======================
Package Name: deltarpm
New Branches: EL-4 EL-5

See https://bugzilla.redhat.com/show_bug.cgi?id=426959

Thanks.  If I'm supposed to do this elsewhere, let me know.
Comment 10 Kevin Fenzi 2007-12-29 21:29:16 UTC 
You forgot to reset the fedora-cvs flag, but I noticed this request on the
review list. ;) 

cvs done.
Note You need to log in before you can comment on or make changes to this bug.