Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 202317 - Review Request: perl-File-HomeDir - Get the home directory for yourself or other users
Summary: Review Request: perl-File-HomeDir - Get the home directory for yourself or ot...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-08-12 18:45 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-15 14:40:55 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-08-12 18:45:14 UTC 
Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-File-HomeDir.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-File-HomeDir-0.58-1.src.rpm

Description:
File::HomeDir is a module for dealing with issues relating to the
location of directories for various purposes that are "owned" by a
user, and to solve these problems consistently across a wide variety
of platforms.
Comment 1 Jose Pedro Oliveira 2006-08-12 18:49:24 UTC 
Note:
This module is new requirement of perl-AppConfig (version 1.63).
Comment 2 Jason Tibbitts 2006-08-13 03:01:58 UTC 
Boring easy Perl module review follows:

* source files match upstream:
   295ee8b4f580bea5fa5714cdf8ac965b  File-HomeDir-0.58.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(File::HomeDir) = 0.58
   perl(File::HomeDir::Darwin) = 0.58
   perl(File::HomeDir::MacOS9) = 0.58
   perl(File::HomeDir::TIE)
   perl(File::HomeDir::Unix) = 0.58
   perl(File::HomeDir::Windows) = 0.58
   perl-File-HomeDir = 0.58-1.fc6
  =
   perl >= 0:5.005
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(File::Spec)
   perl(base)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful, 4 subtests skipped.
   Files=3, Tests=35,  0 wallclock secs ( 0.10 cusr +  0.04 csys =  0.14 CPU)
  (the skipped dests are meaningless except on Windows)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED
Comment 3 Jose Pedro Oliveira 2006-08-13 11:40:55 UTC 
Thanks for the review.

Imported and built for development.
Pending FC-5 branch creation.
Comment 4 Jose Pedro Oliveira 2006-08-15 14:40:55 UTC 
Also build for FC-5.
Note You need to log in before you can comment on or make changes to this bug.