Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 2039531 - Review Request: python-pyqt-feedback-flow - Show feedbacks in toast-like notifications
Summary: Review Request: python-pyqt-feedback-flow - Show feedbacks in toast-like noti...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: fedora-neuro, NeuroFedora
TreeView+ depends on / blocked
Reported: 2022-01-11 21:30 UTC by Iztok Fister Jr.
Modified: 2022-01-17 13:42 UTC (History)
3 users (show)

Fixed In Version: python-pyqt-feedback-flow-0.1.1-1.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2022-01-17 13:42:52 UTC
Type: ---
code: fedora-review+

Attachments (Terms of Use)

Description Iztok Fister Jr. 2022-01-11 21:30:18 UTC
Spec URL:

Description: This is a very simple module for showing simple notifications during the cycling training sessions in order to pass on a cyclist`s essential
information, as well as information that can be submitted by a sport trainer.
This software allows us to show notification in the realm of a text or a
picture. It was shown that flowing feedback is more appropriate for
a cyclist than static notification or pop up windows. It can also be
integrated into existing PyQt projects very easily.

Fedora Account System Username: iztokf

Comment 1 Ben Beasley 2022-01-12 15:01:33 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- Under the new Python guidelines, you must run some sort of test. If there are
  upstream tests, you should try to run them if possible. Otherwise, you can do
  a basic import smoke test.

  In this case, the upstream tests appear to be just a placeholder, so I would
  normally recommend doing both, i.e., add

    BuildRequires:  %{py3_dist pytest}


    # Upstream tests are currently just a placeholder; do an import smoke test too.

  but the single placeholder test doesn’t even work because it checks for the
  wrong version number, so perhaps leave out the pytest BR and just add:

    # Upstream tests are currently just a (failing) placholder, so do an import
    # smoke test instead.

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 23 files have unknown license. Detailed output of
     licensecheck in /home/reviewer/2039531-python-pyqt-feedback-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python

     If there are no upstream tests, you must run an import “smoke test.”

[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[!]: %check is present and all tests pass.

     If there are no upstream tests, you must run an import “smoke test.”

[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Cannot parse rpmlint output:

Rpmlint (installed packages)
Cannot parse rpmlint output:

Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : ae2ce229c59e5abf2b17a4c5996fe62f701b2f2add217e71d36542a33238f69e
  CHECKSUM(SHA256) upstream package : ae2ce229c59e5abf2b17a4c5996fe62f701b2f2add217e71d36542a33238f69e

python3-pyqt-feedback-flow (rpmlib, GLIBC filtered):


Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2039531
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: Ocaml, Perl, SugarActivity, fonts, Java, R, PHP, Haskell, C/C++
============================ rpmlint session starts ============================
rpmlint: 2.2.0
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s

Comment 3 Ben Beasley 2022-01-12 17:58:12 UTC
Approved by inspection of the spec file diff.

Note that the BuildRequires on pytest is not actually needed if you are only running %pyproject_check_import.

--- ../srpm-unpacked/python-pyqt-feedback-flow.spec     2022-01-11 16:03:36.000000000 -0500
+++ 2039531-python-pyqt-feedback-flow/srpm-unpacked/python-pyqt-feedback-flow.spec      2022-01-12 10:43:52.000000000 -0500
@@ -23,6 +23,7 @@
 BuildRequires:  python3-devel
 BuildRequires:  %{py3_dist toml-adapt}
+BuildRequires:  %{py3_dist pytest}
 %description %_description
@@ -50,6 +51,10 @@
 %pyproject_save_files pyqt_feedback_flow
+# use smoke test
 %files -n python3-%{pypi_name} -f %{pyproject_files}
 %license LICENSE

Comment 4 Gwyn Ciesla 2022-01-12 20:07:24 UTC
(fedscm-admin):  The Pagure repository was created at

Note You need to log in before you can comment on or make changes to this bug.