Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 204560 - Review Request: python-pydns - Another Pyhon DNS library.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 204561
TreeView+ depends on / blocked
Reported: 2006-08-29 23:49 UTC by jafo-redhat
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-09-01 19:10:11 UTC
Type: ---
kevin: fedora-cvs+

Attachments (Terms of Use)

Description jafo-redhat 2006-08-29 23:49:28 UTC
Spec URL:
Description: Another Python DNS library, this one is based on Guido's original code, updated by Anthony Baxter.  It is required for the PySPF package.

This is my first package and I need a sponsor.

Comment 1 Kevin Fenzi 2006-08-30 02:48:11 UTC
I'd be happy to take a look at this (and pyspf). 

Your SRPM link seems to be pointing to the noarch instead of the src.rpm... 
can you provide an updated link? :)

Comment 2 Kevin Fenzi 2006-08-30 03:18:27 UTC
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
See below - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
See below - Should include License or ask upstream to include it.
OK - Should build in mock.


1. Should the license really be "Python Software Foundation License"
and not "Python license" ? a grep in the unpacked source gives:
PKG-INFO:License: Python license
README.txt:This code is released under a Python-style license.        license = 'Python license',

2. You should provide a full path to the source in Source0.
Perhaps something like:

3. You need to own the %{python_sitelib}/DNS/ directory, not just
it's contents.

4. rpmlint says:
W: python-pydns summary-ended-with-dot Python module for DNS (Domain Name 
Suggest: remove the . at the end of the summary line.

5. You BuildRequire python-setuptools, according to the python package
guidelines ( at ),
"Python packages that use setuptools need to add python-setuptools 
as a BuildRequires and must either add --single-version-externally-managed 
to the line invoking in %install, or must add a .pth file 
containing the path to the egg or egg directory to %{python_sitelib}."
Should this package do that? Or does it really need python-setuptools at all?

Comment 3 jafo-redhat 2006-08-30 09:47:42 UTC
Sorry about that.  Here's the SRPM:


Comment 4 jafo-redhat 2006-08-30 10:06:16 UTC
Thanks for the pointers, Kevin.

Spec URL:

Comment 5 Kevin Fenzi 2006-08-31 02:23:02 UTC
ok, all the 5 issues above from comment #2 are fixed... 
one new thing however, you're missing a changelog entry for the -2 release. 

Fix that up and I think this will be all ready for approval. 

Comment 6 jafo-redhat 2006-08-31 06:09:54 UTC
I've changed this to include a changelog for -3.  I hope this is ok, as I pretty
much consider everything <-3 to be part of the initial packaging, since I
haven't released them otherwise.

Spec URL:

Comment 7 jafo-redhat 2006-08-31 21:31:27 UTC
This version has changelog entries for the -2

Spec URL:

Comment 8 Kevin Fenzi 2006-09-01 01:17:22 UTC
looks good. This package is APPROVED. 

I'd be happy to sponsor you... 

Continue the process from the "get a fedora account" section on:

Comment 9 jafo-redhat 2006-09-01 19:10:11 UTC
The package was imported and built.

Comment 10 Sean Reifschneider 2007-06-11 23:33:48 UTC
Package Change Request
Package Name: python-pydns
New Branches: EL-5

To get into EPEL.

Comment 11 Kevin Fenzi 2007-06-11 23:43:48 UTC
branch done. 

Note You need to log in before you can comment on or make changes to this bug.