Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2051229 - Review Request: rust-wasi-common - WASI implementation in Rust
Summary: Review Request: rust-wasi-common - WASI implementation in Rust
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Aleksei Bavshin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2051222
Blocks: FE-Legal 2051232 2051234 2051237
TreeView+ depends on / blocked
 
Reported: 2022-02-06 16:18 UTC by Fabio Valentini
Modified: 2022-08-09 15:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-09 15:30:41 UTC
Type: ---
Embargoed:
alebastr89: fedora-review?


Attachments (Terms of Use)

Description Fabio Valentini 2022-02-06 16:18:25 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-wasi-common.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-wasi-common-0.33.0-1.fc35.src.rpm

Description:
WASI implementation in Rust.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2022-02-06 17:26:07 UTC
Successful COPR builds of all packages for all available architectures:
https://copr.fedorainfracloud.org/coprs/decathorpe/wasmtime/monitor/

Comment 2 Aleksei Bavshin 2022-03-10 05:56:16 UTC
Uh. `/WASI/` is a git submodule pointing to the WebAssembly System Interface project[1] (I guess?) which doesn't declare a license[2].
Can you clarify the license for these files and add a comment in the spec file? Note that the submodule is updated in newer wasi-common versions.

[1]: https://github.com/WebAssembly/WASI/tree/5ab83a68d4eb4f218a898ed03b963b7393caaedc
[2]: https://github.com/WebAssembly/WASI/issues/182

Comment 3 Fabio Valentini 2022-03-10 11:49:47 UTC
Ugh, good catch. I somehow didn't realize that this is a git submodule.

I've commented on that WASI issue, and opened an issue with wasmtime as well:

https://github.com/WebAssembly/WASI/issues/182#issuecomment-1063971585
https://github.com/bytecodealliance/wasmtime/issues/3912

Comment 4 Fabio Valentini 2022-03-19 11:21:55 UTC
It looks like upstream opinion is that the included .witx files are not copyrightable at all (as they describe an API).

They are looking to make this explicit by adding a notice that they're released into the Public Domain or licensed as CC0:
https://github.com/WebAssembly/WASI/issues/182#issuecomment-1067814236

Would including a link to these GitHub issues be enough to get this package going for now?

Comment 5 Aleksei Bavshin 2022-03-20 20:24:04 UTC
(In reply to Fabio Valentini from comment #4)
> It looks like upstream opinion is that the included .witx files are not
> copyrightable at all (as they describe an API).

IANAL, but I'm not sure if Google LLC v. Oracle America, Inc upstream refers to is directly applicable here. It was about fair use of the APIs, but here we have files with API description clearly authored by someone. In my mind the difference is like between POSIX APIs and corresponding glibc header files.
If it works though, it works in the US which should be sufficient for Fedora.

> They are looking to make this explicit by adding a notice that they're
> released into the Public Domain or licensed as CC0:
> https://github.com/WebAssembly/WASI/issues/182#issuecomment-1067814236
> 
> Would including a link to these GitHub issues be enough to get this package
> going for now?

I have no technical issues with the package.
As discussed on IRC, blocking FE-Legal to clarify the .witx licensing before approving.

Comment 6 Fabio Valentini 2022-04-19 13:30:33 UTC
Updated to 0.35.3, matching versions of dependencies and dependent packages in Fedora and COPR:

Spec URL: https://decathorpe.fedorapeople.org/rust-wasi-common.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-wasi-common-0.35.3-1.fc36.src.rpm

(Upstream has still not clarified the .witx file license.)

Comment 7 Richard Fontana 2022-08-05 20:40:43 UTC
Possibly significant: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/RRYM3CLYJYW64VSQIXY6IF3TCDZGS6LM/ (CC0 no longer allowed in Fedora for 'code')

Comment 8 Fabio Valentini 2022-08-05 22:05:17 UTC
(CC0 no longer allowed in Fedora for 'code')

Wow, that's not a thing that I expected to read.

As for the witx files from the WASI repository (the problem in that's blocking this package review):
I'm not even sure if non-executable interface descriptions would qualify as "code" or "content"?

And if you have opinions or suggestions here, could you please leave them as comments on the GitHub issues?
I don't seem to have any leverage for making things happen here.

Comment 9 Fabio Valentini 2022-08-09 15:30:41 UTC
I have abandoned my effort to package wasmtime.


Note You need to log in before you can comment on or make changes to this bug.