Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 205314 (perl-Class-C3) - Review Request: perl-Class-C3 - Pragma to use the C3 method resolution order algorithm
Summary: Review Request: perl-Class-C3 - Pragma to use the C3 method resolution order ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Class-C3
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Class-C3/
Whiteboard:
Depends On: perl-Algorithm-C3
Blocks: FE-ACCEPT perl-Class-MOP
TreeView+ depends on / blocked
 
Reported: 2006-09-05 23:28 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-07 23:14:46 UTC
Type: ---
Embargoed:
jwboyer: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2006-09-05 23:28:46 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-C3-0.13-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Class-C3.spec

Description:
This is a pragma to change Perl 5's standard method resolution order from depth-
first left-to-right (a.k.a - pre-order) to the more sophisticated C3 method
resolution order.

Comment 1 Patrice Dumas 2006-09-07 07:56:58 UTC
There is a missing BuildRequires perl(Sub::Name) for a test 
t/33_next_method_used_with_NEXT.t.
And also certainly perl(UNIVERSAL::can) for t/01_MRO.t and
 t/30_next_method.t 

There is also a rpmlint warning which is certainly right:
E: perl-Class-C3 description-line-too-long This is a pragma to change Perl 5's
standard method resolution order from depth-

Comment 2 Chris Weyl 2006-09-07 20:22:13 UTC
Updated:

SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-C3-0.13-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Class-C3.spec

(also checked build in mock, now <grin>)

Comment 3 Patrice Dumas 2006-09-07 20:27:42 UTC
Why don't you BR perl(UNIVERSAL::can)?

Comment 4 Chris Weyl 2006-09-07 20:47:52 UTC
perl(UNIVERSAL::can) is both a module and a method; this code looks to build OK
with the can method supplied by perl(UNIVERSAL) in base.  (And more to point,
doesn't appear to 'use UNIVERSAL::can;' anywhere.)

Comment 5 Patrice Dumas 2006-09-07 21:49:55 UTC
Ok, you're right.

* rpmlint is silent
* package named according to guidelines
* free software, without licence files included
* meets packaging guidelines
* spec legible
* source match upstream
95b52572a765b9d9103b264a15e323a1  Class-C3-0.13.tar.gz
* sane provides
Provides: perl(Class::C3) = 0.01
* %files right

APPROVED

Comment 6 Chris Weyl 2006-09-07 23:13:44 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+Request branching (FC-5)
+Close bug

Thanks for the review! :)

Comment 7 Chris Weyl 2007-04-19 20:41:09 UTC
Please branch for EL-4, EL-5.


Note You need to log in before you can comment on or make changes to this bug.