Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 206839 - Review Request: python-turbokid - Python template plugin that supports Kid templates
Summary: Review Request: python-turbokid - Python template plugin that supports Kid te...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Toshio Kuratomi
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 189338
TreeView+ depends on / blocked
 
Reported: 2006-09-17 05:24 UTC by Luke Macken
Modified: 2016-09-20 02:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-30 06:27:17 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Luke Macken 2006-09-17 05:24:33 UTC 
Spec URL: http://people.redhat.com/lmacken/SPECS/TurboKid.spec
SRPM URL: http://people.redhat.com/lmacken/RPMS/TurboKid-0.9.8-2.src.rpm
Description:
This package provides a template engine plugin, allowing you
to easily use Kid with TurboGears, Buffet or other systems
that support python.templating.engines.
Comment 1 Toshio Kuratomi 2006-09-23 04:04:09 UTC 
MD5Sums:

59c0ee439ad02613965017e38b6796d0  TurboKid-0.9.8-2.src.rpm
35997fd4208f40279461b6a823a4e03f  TurboKid-0.9.8-py2.4.egg
f7a9046bb1d065aa13fad23ba6363018  TurboKid.spec

Blockers:
* As we discussed on IRC the naming is better as python-turbogears.
* Upstream seems to have changed the download URL to:
  http://files.turbogears.org/eggs/TurboKid-0.9.8-py2.4.egg
* Package needs to own the %{python_sitelib}/turbokid directory.  Removing
  the (*) from the relevant line in %files should take care of that.
* We should try to place the EGG-INFO directory into the site-packages
  directory so that setuptools realizes we have it installed.  From our IRC
  conversation it sounds like you have a better idea of how this should look
  than I do :-)

Good:
* Package licensed under a MIT style license.
* The spec file is legible, American English.
* Source matches upstream.
* Package compiles and builds as noarch on an x86_64.
* All BuildRequires are satisfied.
* No locales.
* No shared libraries, static libraries, headers, or pkgconfig files.
* Not relocatable.
* No duplicate files.
* Permissions properly set.
* Proper %clean section.
* Macros are properly used.
* No large docs.  Docs do not affect runtime.
* No GUI application.
* Does not own directories already owned.
* Builds in mock
* rpmlint -i TurboKid-0.9.8-2.noarch.rpm
  W: TurboKid no-documentation
  Hopefully upstream will include more documentation in the future.

Not Yet checked:
* Tested that it works.  I have to build a new TurboGears package to test this
  with.

If you fix the blockers, I'll get TurboGears built so I can test and we can get
this approved.
Comment 2 Luke Macken 2006-09-23 06:17:10 UTC 
http://people.redhat.com/lmacken/RPMS/python-turbokid-0.9.8-3.src.rpm
http://people.redhat.com/lmacken/SPECS/python-turbokid.spec

* Sat Sep 23 2006 Luke Macken <lmacken> - 0.9.8-3
- Rename to python-turbokid
- Own %%{python_sitelib}/turbokid directory
- Install the EGG-INFO directory
Comment 3 Toshio Kuratomi 2006-09-28 06:58:30 UTC 
MD5Sums:
582b11e91d8c4369bdf2be424624d1e0  python-turbokid-0.9.8-3.src.rpm
35997fd4208f40279461b6a823a4e03f  TurboKid-0.9.8-py2.4.egg
a88645a5afc9b70685c977ac0afd7a5c  python-turbokid.spec

Good:
* The three blockers have been fixed.
* Tested with turbogears 1.0-0.1.b1 and proposed python-turbojson package and it
runs a minimal test.

APPROVED
Comment 4 Luke Macken 2006-09-30 06:27:17 UTC 
Imported into CVS, added to owners.list, requested FC-5 branch, and bumped to 0.9.9.
Comment 5 Kevin Fenzi 2006-12-22 03:15:55 UTC 
Changing summary for tracking purposes.
Comment 6 Dan Callaghan 2014-07-15 01:16:54 UTC 
Please un-retire the epel7 branch.

Package Change Request
======================
Package Name: python-turbokid
New Branches: epel7
Owners: dcallagh
Comment 7 Gwyn Ciesla 2014-07-15 12:29:33 UTC 
Complete.
Note You need to log in before you can comment on or make changes to this bug.