Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 207265 - Review Request: python-zope-interface - Zope interfaces package
Summary: Review Request: python-zope-interface - Zope interfaces package
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeffrey C. Ollie
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 171543 208169
TreeView+ depends on / blocked
 
Reported: 2006-09-20 10:03 UTC by Paul Howarth
Modified: 2008-02-18 18:19 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-02 12:53:52 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Paul Howarth 2006-09-20 10:03:08 UTC 
Spec URL: http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-interface.spec
SRPM URL: http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-interface-3.0.1-5.src.rpm
Description: 

This is a separate distribution of the zope.interface package used in Zope 3.

It is a dependency of the Twisted 2.x stack (see Bug #171543).
Comment 1 Daniel Benamy 2006-10-18 21:14:17 UTC 
It looks like it's missing a build dep on gcc.
Comment 2 Paul Howarth 2006-10-19 07:03:17 UTC 
Buildreqs of gcc don't need to be included; see:

http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions
Comment 3 Jeffrey C. Ollie 2006-10-29 13:47:00 UTC 
* source files match upstream (can't compare MD5 since this package
  currently uses a CVS snapshot).
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
? can't check it in mock right now because my mock isn't behaving
  properly right now
* package installs properly
* rpmlint comes up empty
! %check is not present; There are some unit tests in
  zope.interface.tests
* no shared libraries, .so file is a Python C module
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers
* unversioned .so file is a Python C module, no -devel package necessary
* no pkgconfig files.
* no libtool .la droppings.

APPROVED, once the %check is added
Comment 4 Jeffrey C. Ollie 2006-10-30 20:42:40 UTC 
I've gotten mock fixed so I'm able to confirm that it builds in FC6/i386
Comment 5 Paul Howarth 2006-10-31 17:04:01 UTC 
Spec URL:
http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-interface.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/python-zope-interface/python-zope-interface-3.0.1-6.src.rpm

Release 6 adds %check section; hope I got that right.

I have tested that this version builds OK in mock for FC4..rawhide (i386 and
x86_64), though I'm only intending to request builds back to FC5.
Comment 6 Jeffrey C. Ollie 2006-10-31 17:27:17 UTC 
Looks good, go ahead and import!
Comment 7 Paul Howarth 2006-11-02 12:53:52 UTC 
Imported and built successfully for FC-5, FC-6, and development.
owners.list updated.

Thanks for the review.
Comment 8 Lubomir Kundrak 2008-02-17 16:19:41 UTC 
Paul: I'm interested in EL-5 branch. Would you maintain it yourself or you
won't mind if I maintained it?
Comment 9 Paul Howarth 2008-02-17 18:26:21 UTC 
Package Change Request
======================
Package Name: python-zope-interface
New Branches: EL-4 EL-5
Comment 10 Paul Howarth 2008-02-17 18:27:54 UTC 
Lubomir: I'm OK to maintain this myself but I'll happily add you as
co-maintainer for both Fedora and EPEL if you want.
Comment 11 Kevin Fenzi 2008-02-18 17:18:55 UTC 
cvs done.
Comment 12 Paul Howarth 2008-02-18 18:19:33 UTC 
Branched and built for EPEL4 and EPEL5:

38372 (python-zope-interface): Build on target fedora-4-epel succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-4-epel/38372-python-zope-interface-3.0.1-10.el4/

38371 (python-zope-interface): Build on target fedora-5-epel succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-5-epel/38371-python-zope-interface-3.0.1-10.el5/
Note You need to log in before you can comment on or make changes to this bug.