Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 208006 - Review Request: perl-Time-Period - A Perl module to deal with time periods
Summary: Review Request: perl-Time-Period - A Perl module to deal with time periods
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-09-25 19:46 UTC by Robert Marcano
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-26 03:23:14 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Robert Marcano 2006-09-25 19:46:07 UTC 
Spec URL: http://www.marcanoonline.com/downloads/fedora/package_submissions/perl-Time-Period/perl-Time-Period.spec
SRPM URL: http://www.marcanoonline.com/downloads/fedora/package_submissions/perl-Time-Period/perl-Time-Period-1.20-1.src.rpm
Description: Period.pm is a Perl module that contains code to deal with time periods.
Comment 1 Jason Tibbitts 2006-09-26 01:41:43 UTC 
* source files match upstream:
   63b073af8ec96e7fa48801cd6fcccdd1  Period-1.20.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is unnecessary)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Time::Period) = 1.20
   perl-Time-Period = 1.20-1.fc6
  =
   perl >= 0:5.001
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
* %check is present but the package has no tests to run.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Note You need to log in before you can comment on or make changes to this bug.