Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 208051 - Review Request: dirvish - Fast, disk based, rotating network backup system
Summary: Review Request: dirvish - Fast, disk based, rotating network backup system
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-09-26 03:27 UTC by Robert Marcano
Modified: 2009-04-07 03:13 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-10-06 01:44:57 UTC
Type: ---
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Robert Marcano 2006-09-26 03:27:12 UTC
Spec URL:
Dirvish is a fast, disk based, rotating network backup system. With dirvish you
can maintain a set of complete images of your filesystems with unattended
creation and expiration. A dirvish backup vault is like a time machine for your

Comment 1 Jason Tibbitts 2006-10-05 16:07:08 UTC
First off, the spec says GPL but the license in certainly not the GPL:
    Licensed under the Open Software License version 2.0
And as a bonus, v2.0 of that license shouldn't be used.  But I think it's still
open source; it was version 1.1 that had problems.

Also, the actual license needs to be included in the package, since it's present
in the tarball.

* source files match upstream:
   892ec9333b19e623880cdb499443c11b  dirvish-1.2.1.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.
X License text included upstream but is not in the final package.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is not necessary)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   dirvish = 1.2.1-1.fc6
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* not a GUI app.

Comment 2 Robert Marcano 2006-10-05 17:28:31 UTC
ooooops big mistake.. fixed

the OSL 2.0 is not recommended any more (it was superceded by version 2.1 and
3.0 but it was approved by the OSI (see

Comment 3 Jason Tibbitts 2006-10-05 23:14:58 UTC
Builds fine and looks good.  The only issue is that rpmlint is now complaining:
  W: dirvish invalid-license OSL
The license tag accurately describes the license, so this should be OK.


Comment 4 Robert Marcano 2006-10-06 01:44:57 UTC

Comment 5 Robert Marcano 2009-04-06 13:10:58 UTC
Package Change Request
Package Name: dirvish
New Branches: EL-5
Owners: robmv

Comment 6 Kevin Fenzi 2009-04-07 03:13:29 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.