Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 208915 - Review Request: php-pear-PHPUnit - Regression testing framework for unit tests
Summary: Review Request: php-pear-PHPUnit - Regression testing framework for unit tests
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-02 16:46 UTC by Remi Collet
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-08 16:00:24 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Remi Collet 2006-10-02 16:46:38 UTC 
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-PHPUnit.spec
SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-PHPUnit-1.3.2-1.fc5.src.rpm
Description: 
PHPUnit is a regression testing framework used by the developer who
implements unit tests in PHP. This is the version to be used with PHP 4.

Developper should use PHPUnit2 with PHP5.

----
I think this extension still useful (when PHPUnit2 is available) to test older packages  which provide a test suite using this tools.

For exemple, to test php-pear-Console-Getargs, youd should run
cd /usr/share/pear/test/Console_Getargs/tests && php -q test.php
---
rpmlint does not complain.
build in mock : http://remi.collet.free.fr/rpms/extras/php-pear-PHPUnit-build.log
Comment 1 Jason Tibbitts 2006-10-03 01:15:10 UTC 
I suggest you change the last line of the summary to:

  Developers should use PHPUnit2 with PHP5.

to be grammatical.  Other than that, everything is fine.

* source files match upstream:
   4b9dd2158e4035318481c93bbd59aaa5  PHPUnit-1.3.2.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(PHPUnit) = 1.3.2
   php-pear-PHPUnit = 1.3.2-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   php >= 4.3.0
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Note You need to log in before you can comment on or make changes to this bug.