Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 209264 - Review Request: emerald-themes - Themes for Emerald, the window decorator for Beryl
Summary: Review Request: emerald-themes - Themes for Emerald, the window decorator for...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michał Bentkowski
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 209259
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-04 06:31 UTC by Jarod Wilson
Modified: 2011-04-05 15:17 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-21 20:58:12 UTC
Type: ---
Embargoed:
j: fedora-cvs+

Attachments (Terms of Use)

Description Jarod Wilson 2006-10-04 06:31:00 UTC 
Spec URL: http://wilsonet.com/packages/beryl/emerald-themes.spec
SRPM URL: http://wilsonet.com/packages/beryl/emerald-themes-0.1.0-1.fc6.src.rpm
Description:
--
Emerald is themeable window decorator and compositing 
manager for Beryl. Launch Theme Manager from
beryl-manager to change themes.

This package contains themes for emerald.
--

NOTE: This package depends on beryl-core, under review here: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209259, as well as emerald, under review here: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209263.
Comment 1 Jarod Wilson 2006-10-26 15:45:16 UTC 
Just pushed a 0.1.1 build out:

http://wilsonet.com/packages/beryl/emerald-themes-0.1.1-1.fc6.src.rpm
Comment 2 Martin Sourada 2006-11-14 17:55:02 UTC 
You should fix this rpmlint output:
E: emerald-themes non-executable-script /usr/share/emerald/themes/import.sh 0644
Comment 3 Jarod Wilson 2006-11-14 19:18:00 UTC 
(In reply to comment #2)
> You should fix this rpmlint output:
> E: emerald-themes non-executable-script /usr/share/emerald/themes/import.sh 0644
> 

I've removed it from the package entirely, its only needed at build time. That
change, plus the switch to the upstream tarball are in the latest build:

http://wilsonet.com/packages/beryl/emerald-themes-0.1.2-2.fc6.src.rpm
Comment 4 Michał Bentkowski 2006-11-16 15:00:31 UTC 
MUST items:
 * rpmlint is quiet
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with a GPL open-source compatible license 
 * License field in spec file matches actual license
 * license file is included in %doc
 * md5sums are matching (c5aa35e30d3476f05a469f1baac16341)
 * package successfully compiles on x86_64
 * BuildRequires listed well
 * no locales
 * no need to %post and %postun sections
 * not relocatable
 * package owns directories well
 * no duplicates in %files
 * every %files section includes %defattr
 * proper %clean section
 * macros used well

This package is obviosly approved :)
Comment 5 Jarod Wilson 2006-11-16 15:43:13 UTC 
Imported and built for devel, FC6 branch requested.
Comment 6 leigh scott 2011-04-04 23:29:19 UTC 
Package Change Request
======================
Package Name: emerald-themes
New Branches: el6
Owners: leigh123linux
Comment 7 Jason Tibbitts 2011-04-05 15:17:42 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.