Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 209948 - Review Request: telepathy-feed - Galago feed for Telepathy
Summary: Review Request: telepathy-feed - Galago feed for Telepathy
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-08 18:06 UTC by Brian Pepple
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-13 14:37:30 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Brian Pepple 2006-10-08 18:06:32 UTC
Spec URL: http://piedmont.homelinux.org/fedora/telepathy/telepathy-feed.spec
SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/telepathy-feed-0.13-1.src.rpm
Description: A Galago feed for Telepathy

Note: This will only build on Rawhide currently until libgalago is updated in FC5.  Also, this package will need to require a galago-filesystem package since multiple packages now use '%{_libdir}/galago/'

Spec URL: http://piedmont.homelinux.org/fedora/telepathy/galago-filesystem.spec
SRPM URL: http://piedmont.homelinux.org/fedora/telepathy/galago-filesystem-0.0.1-1.src.rpm
Description: Galago filesystem layout

Comment 1 Mamoru TASAKA 2006-10-11 08:26:10 UTC
I will review this later.

Comment 2 Mamoru TASAKA 2006-10-11 14:13:33 UTC
Well, 

W: galago-filesystem no-url-tag (for src.rpm)
W: galago-filesystem no-%build-section (for src.rpm)

The formar warning can be ignored.
no-%build-section warning says:
------------------------------------------------------------------------------
The spec file does not contain a %build section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality, such as
injection of automatic -debuginfo subpackages.  Add the section, even if
empty.
------------------------------------------------------------------------------
It seems that adding %build section is preferable even if
it seems nonsense.


------------------------------------------------------------------------------
 These packages (telepathy-feed & galago-filesystem) are
 APPROVED by me.

Comment 3 Brian Pepple 2006-10-13 14:37:30 UTC
Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.