Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 210785 (pear-XML-Beautifier) - Review Request: php-pear-XML-Beautifier - Class to format XML documents
Summary: Review Request: php-pear-XML-Beautifier - Class to format XML documents
Keywords:
Status: CLOSED NEXTRELEASE
Alias: pear-XML-Beautifier
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-15 00:07 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-17 03:30:42 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Stone 2006-10-15 00:07:19 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-Beautifier.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-Beautifier-1.1-1.src.rpm

Description:

XML_Beautifier is a package, that helps you making XML documents easier to
read for human beings.

It is able to add line-breaks, indentation, sorts attributes, convert tag
cases and wraps long comments. It recognizes tags, character data, comments,
XML declarations, processing instructions and external entities and is able
to format these tokens nicely.

The document is split into these tokens using the XML_Beautifier_Tokenizer
class and the expat parser. Then a renderer is used to create the string
representation of the document and formats it using the specified options.

Currently only one renderer is available, but as XML_Beautifier uses a
driver-based architecture, other renderers (like syntax-highlighting)
will follow soon.
Comment 1 Jason Tibbitts 2006-10-16 00:18:20 UTC 
* source files match upstream:
   d121758edb840d9107debb26bb5837d7  XML_Beautifier-1.1.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(XML_Beautifier) = 1.1
   php-pear-XML-Beautifier = 1.1-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
   php-pear(XML_Parser)
   php-pear(XML_Util)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Comment 2 Christopher Stone 2006-10-17 03:30:42 UTC 
Imported and built, thanks for the review.
Comment 3 Christopher Stone 2007-04-22 22:39:16 UTC 
Branch Package CVS Request
=======================
Package Name: php-pear-XML-Beautifier
Short Description: Class to format XML documents
Owners: chris.stone
Branches: EL-5
InitialCC:
Note You need to log in before you can comment on or make changes to this bug.