Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 211317 - Review Request: perl-Cache-Mmap - Shared data cache using memory mapped files
Summary: Review Request: perl-Cache-Mmap - Shared data cache using memory mapped files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-18 16:56 UTC by Steven Pritchard
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-10-26 00:54:56 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Steven Pritchard 2006-10-18 16:56:52 UTC
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Cache-Mmap/perl-Cache-Mmap.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Cache-Mmap-0.09-1.src.rpm
Description:
This module implements a shared data cache, using memory mapped files. If
routines are provided which interact with the underlying data, access to
the cache is completely transparent, and the module handles all the details
of refreshing cache contents, and updating underlying data, if necessary.

Comment 1 Patrice Dumas 2006-10-18 17:39:14 UTC
* rpmlint error:
E: perl-Cache-Mmap wrong-script-interpreter
/usr/share/doc/perl-Cache-Mmap-0.09/cmmtest "/usr/local/bin/perl-journals"

This is indeed true, and maybe a simple sed line could correct
the shebang in cmmtest. I won't make it a blocker.
* free software, licence not included
* follow guidelines
* spec legible
* match upstream
fef44673771a0f1f14982ae719f57221  Cache-Mmap-0.09.tar.gz
* sane provides (Mmap.so is wrong, but it's usual)
Provides: Mmap.so perl(Cache::Mmap)
* %files section right

APPROVED

Comment 2 Steven Pritchard 2006-10-18 23:12:58 UTC
First, thank you for the quick review.

(In reply to comment #1)
> * rpmlint error:
> E: perl-Cache-Mmap wrong-script-interpreter
> /usr/share/doc/perl-Cache-Mmap-0.09/cmmtest "/usr/local/bin/perl-journals"
> 
> This is indeed true, and maybe a simple sed line could correct
> the shebang in cmmtest.

I didn't think it was significant, since it is a %doc file.  (And note that I
chmod a-x the thing in %prep, so there's no danger of mistaking it for a real
script, and it isn't causing any new dependencies.)

In other words, I'd prefer to leave it as-is.  Besides, I have to assume
upstream had some reason for it...

Comment 3 Patrice Dumas 2006-10-19 07:04:38 UTC
(In reply to comment #2)

> I didn't think it was significant, since it is a %doc file.  (And note that I
> chmod a-x the thing in %prep, so there's no danger of mistaking it for a real
> script, and it isn't causing any new dependencies.)

Indeed, and that's why I don't make it a blocker.

> In other words, I'd prefer to leave it as-is.  Besides, I have to assume
> upstream had some reason for it...

Some reason we don't care about. In fedora it would be  better in my 
opinion if a user wouldn't have to guess why the shebang is like that
and whether he has to install something else to have the package work.
This example is meant to be read, so it should be as correct as possible.


Comment 4 Steven Pritchard 2006-10-26 00:54:56 UTC
Imported, built, etc.


Note You need to log in before you can comment on or make changes to this bug.