Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2113870 - Review Request: perl-IO-Compress-Brotli - Brotli compression library for perl
Summary: Review Request: perl-IO-Compress-Brotli - Brotli compression library for perl
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR 2096953
TreeView+ depends on / blocked
 
Reported: 2022-08-02 08:31 UTC by Petr Salaba
Modified: 2022-08-18 12:55 UTC (History)
4 users (show)

Fixed In Version: perl-IO-Compress-Brotli-0.004001-6.fc37 perl-IO-Compress-Brotli-0.004001-6.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-18 12:55:57 UTC
Type: Bug
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Salaba 2022-08-02 08:31:04 UTC
SRPM URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli-0.004001-3.fc37.src.rpm

Spec URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli.spec

Description: This package provides bindings for brotli compression to perl.
Source is taken from the cpan package IO::Compress::Brotli

Fedora Account System Username: psalaba

Comment 1 Michal Josef Spacek 2022-08-02 08:42:17 UTC
FYI: New version of perl-HTTP-Message added support for brotli compression via this module. I am for adding to Fedora as perl-HTTP-Message maintainer.

Comment 2 Jitka Plesnikova 2022-08-02 11:34:11 UTC
Source files are ok
TODO: perl-IO-Compress-Brotli.rpmlintrc can be removed. It isn't necessary
      to add it into rpm. Just add it to git repository.

URL and Source0 are ok

Summary
FIX: Update the text of summary  "Read and write Brotli buffers/streams"

FIX: Remove 'Group' tag. 'Group' should not be used.
     https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

License is ok
Description is ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-IO-Compress-Brotli-0.004001-3.fc37.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libbrotlidec.so.1()(64bit)
      1 libbrotlienc.so.1()(64bit)
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.36()(64bit)
      1 perl(bytes)
      1 perl(Exporter)
      1 perl(File::Slurper)
      1 perl(Getopt::Long)
      1 perl(IO::Compress::Brotli)
      1 perl(IO::Uncompress::Brotli)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(parent)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-IO-Compress-Brotli-0.004001-3.fc37.x86_64.rpm | sort | uniq -c
      1 perl(IO::Compress::Brotli) = 0.004001
      1 perl-IO-Compress-Brotli = 0.004001-3.fc37
      1 perl-IO-Compress-Brotli(x86-64) = 0.004001-3.fc37
      1 perl(IO::Uncompress::Brotli) = 0.004001
Binary provides are Ok.

$ rpmlint -r perl-IO-Compress-Brotli.rpmlintrc ./perl-IO-Compress-Brotli*
============================ rpmlint session starts ============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('perl-IO-Compress-Brotli.rpmlintrc')]
checks: 32, packages: 4
 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s
Rpmlint is ok

FIX: Remove %defattr from %files section - it is needed only for EPEL =< 6

TODO: I think 'META.json' could be removed from %doc. It does not contain
      any useful information.


Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
Not Approved

Comment 4 Jitka Plesnikova 2022-08-04 14:12:13 UTC
(In reply to Jitka Plesnikova from comment #2)
> Source files are ok
> TODO: perl-IO-Compress-Brotli.rpmlintrc can be removed. It isn't necessary
>       to add it into rpm. Just add it to git repository.
 Source0:        https://cpan.metacpan.org/authors/id/M/MG/MGV/IO-Compress-Brotli-%{version}.tar.gz
-Source1:        perl-IO-Compress-Brotli.rpmlintrc
Ok

> FIX: Update the text of summary  "Read and write Brotli buffers/streams"
-Summary:        Write Brotli buffers/streams
+Summary:        Brotli compression library for perl
Ok.

> FIX: Remove 'Group' tag. 'Group' should not be used.
-Group:          Development/Libraries
Ok.
 
> FIX: Remove %defattr from %files section - it is needed only for EPEL =< 6
> TODO: I think 'META.json' could be removed from %doc. It does not contain
>       any useful information.
-%defattr(-,root,root,-)
-%doc Changes META.json README
+%doc Changes README
Ok.

FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax
https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages
(perl-IO-Compress-Brotli.spec:5).

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct the last 'FIX' item and provide a new spec file.
 
Resolution:
Not Approved

Comment 5 Petr Salaba 2022-08-04 14:28:51 UTC
(In reply to Jitka Plesnikova from comment #4)
> FIX: We have new licensing guidelines. Please write a license tag value in
> SPDX syntax
> https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages
> (perl-IO-Compress-Brotli.spec:5).
> 
> Otherwise the package is in line with Fedora and Perl packaging guide lines.
> Please correct the last 'FIX' item and provide a new spec file.

Understood, I've changed the license to 'GPL-1.0-or-later OR Artistic-1.0-Perl'

SRPM URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli-0.004001-5.fc37.src.rpm
Spec URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli.spec

Comment 6 Jitka Plesnikova 2022-08-05 12:33:00 UTC
(In reply to Jitka Plesnikova from comment #4)
> FIX: We have new licensing guidelines. Please write a license tag value in
> SPDX syntax
> https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages
> (perl-IO-Compress-Brotli.spec:5).
-License:        GPL+ or Artistic
+License:        GPL-1.0-or-later OR Artistic-1.0-Perl
Ok.

The package is in line with Fedora and Perl packaging guide lines.
Resolution:
Approved

Comment 7 Gwyn Ciesla 2022-08-16 13:42:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IO-Compress-Brotli


Note You need to log in before you can comment on or make changes to this bug.