Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2122022 - Review Request: ax86-terminus-ttf-fonts - Terminus TTF is a monospace TrueType Font
Summary: Review Request: ax86-terminus-ttf-fonts - Terminus TTF is a monospace TrueTyp...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Akira TAGOH
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-FONTS
TreeView+ depends on / blocked
 
Reported: 2022-08-28 14:38 UTC by Benson Muite
Modified: 2023-06-04 16:19 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
tagoh: fedora-review?


Attachments (Terms of Use)

Comment 1 Akira TAGOH 2022-10-18 09:40:53 UTC
Before starting the formal review:

1. the foundry is supposed to be set from the foundry property in fontconfig though, "PfEd" is too generic. if upstream doesn't have too much fonts shipped by them, you can simply omit that field. or if "Terminus" is a unique name enough, you can use it instead, like DejaVu.
2. please set correct family name to the family. that should be "Terminus (TTF)". this affects the AppStream file and the wrong name there makes harder to find out the exact font name through AppStream.
3. You don't need "<test name="lang"...><string>en</string>" thing in config.

Comment 2 Benson Muite 2022-10-25 07:09:27 UTC
Thanks for your feedback. Checking with upstream.

Comment 3 Akira TAGOH 2022-10-28 05:00:47 UTC
BTW those are basically Fedora specific thing. I'm not recommending updating the foundry to something. that would be totally optional and there are some exception like "ADBO" vs "Adobe". that depends on how we are identifying. but the proposed name is too long.

Comment 4 Benson Muite 2022-10-28 14:46:17 UTC
Thanks for your feedback.  There are other Terminus fonts. When changing the field in FontConfig, it indicates upto 4 characters should be used.  Thus rather than Tilman Blumenbach, have used TiBl, checking with upstream on this. A few of the glyphs have self intersections and some seem to be incorrectly labelled.  Have not tried to correct these, but can do so if that is typical. Updated spec and srpm:

SPEC: https://download.copr.fedorainfracloud.org/results/fed500/tilman-blumenbach-terminus-mono-fonts/fedora-rawhide-x86_64/04995077-tibl-terminus-ttf-fonts/tibl-terminus-ttf-fonts.spec
SRPM: https://download.copr.fedorainfracloud.org/results/fed500/tilman-blumenbach-terminus-mono-fonts/fedora-rawhide-x86_64/04995077-tibl-terminus-ttf-fonts/tibl-terminus-ttf-fonts-4.49.2-1.fc38.src.rpm

Comment 5 Akira TAGOH 2022-12-21 06:15:25 UTC
No COPYING file in the package.

I'd suggest:
--- tibl-terminus-ttf-fonts.spec.orig        2022-12-21 14:46:50.779287851 +0900
+++ tibl-terminus-ttf-fonts.spec        2022-12-21 15:14:25.781055220 +0900
@@ -30,7 +30,7 @@
 It should also be noted that you need to render Terminus TTF in monochrome
 black/white if the outlines are used; otherwise, they will look smeary.}
 
-%global fonts  terminus-ttf-%{version}/*.ttf
+%global fonts  *.ttf
 %global fontconfs  %{SOURCE10}
 
 Source0: %{url}/files/%{version}/terminus-ttf-%{version}.zip 
@@ -42,9 +42,7 @@
 %fontpkg
 
 %prep
-%setup -q -c
-unzip -n %{SOURCE0}
-pushd terminus-ttf-%{version}
+%setup -q -n terminus-ttf-%{version}
 # Remove space from filename
 mv 'TerminusTTF-Bold Italic-4.49.2.ttf' TerminusTTF-Bold-Italic-4.49.2.ttf
 # Update foundry name
@@ -54,7 +52,6 @@
 fontforge -script UpdateFoundry.pe TerminusTTF-Italic-4.49.2.ttf
 fontforge -script UpdateFoundry.pe TerminusTTF-Bold-4.49.2.ttf
 rm UpdateFoundry.pe
-popd
 
 %build
 %fontbuild

Comment 6 Benson Muite 2022-12-22 08:36:26 UTC
Thanks. Checking with upstream on naming and registration as a foundry.

Comment 8 Akira TAGOH 2023-01-13 12:21:13 UTC
BTW just waiting for the progress on upstream though, I want to bring this up to be sure.

Registering the own foundry name isn't a must. we are considering to pick it up into the package name because it would be easier to recognize if a font is a part of variants/series of fonts made by same font developers/authors - for example, we use the same the foundry prefix in a package name as "google" for google-noto-fonts and google-noto-cjk-fonts.

The question is that do we have another variants/typefaces made by same authors, particularly which can be used together such as sans-serif, serif, and monospace, and/or regional typefaces, etc? if this is a single font or other fonts isn't that useful to use together, we can simply omit the foundry from the package name IMHO. the family name is basically unique. it wouldn't conflicts anything else.

Anyway, I can do the formal review any time.


Note You need to log in before you can comment on or make changes to this bug.