Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212900 (DG-Renderer-Smarty) - Review Request: php-pear-Structures-DataGrid-Renderer-Smarty - Renderer driver using Smarty
Summary: Review Request: php-pear-Structures-DataGrid-Renderer-Smarty - Renderer drive...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: DG-Renderer-Smarty
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: DG-Renderer-Pager
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-30 01:39 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-16 04:18:01 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Christopher Stone 2006-10-30 01:39:27 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-Renderer-Smarty.spec

SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-Renderer-Smarty-0.1.2-1.src.rpm

Description:
This is a Rendering driver for Structures_DataGrid using Smarty. It adds the
necessary variables and functions to a Smarty instance, in order to build a
full-featured DataGrid within a Smarty template.
Comment 1 Jason Tibbitts 2006-11-15 19:19:04 UTC 
Look like there's a typo in one of your Requires: lines:
   php-pear(Strucutres_DataGrid_Renderer_Pager)
                 ^^
Fixing this gets things going.
Comment 2 Jason Tibbitts 2006-11-15 19:48:43 UTC 
Another no-documentation package with an incredibly long name:

W: php-pear-Structures-DataGrid-Renderer-Smarty no-documentation
W: php-pear-Structures-DataGrid-Renderer-Smarty filename-too-long-for-joliet
php-pear-Structures-DataGrid-Renderer-Smarty-0.1.2-1.fc7.noarch.rpm

No blockers, though.

* source files match upstream:
 a5e209d09588b82c3e46b6f4d7fef242  Structures_DataGrid_Renderer_Smarty-0.1.2.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
O rpmlint output is acceptable.
* final provides and requires are sane:
   php-pear(Structures_DataGrid_Renderer_Smarty) = 0.1.2
   php-pear-Structures-DataGrid-Renderer-Smarty = 0.1.2-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-Smarty
   php-pear(PEAR)
   php-pear(Structures_DataGrid_Renderer_Pager)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module installation).
* code, not content.
* no documentation, so no -docs subpackage is necessary.

APPROVED
Comment 3 Christopher Stone 2006-11-16 04:18:01 UTC 
Thanks for the review! :)
Note You need to log in before you can comment on or make changes to this bug.