Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 212924 (pear-DG-Array) - Review Request: php-pear-Structures-DataGrid-DataSource-Array - DataSource driver using arrays
Summary: Review Request: php-pear-Structures-DataGrid-DataSource-Array - DataSource dr...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: pear-DG-Array
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: pear-Structures-DG
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-30 04:57 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-02 20:58:35 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Stone 2006-10-30 04:57:56 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-DataSource-Array.spec

SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-DataSource-Array-0.1.0-1.src.rpm

Description:
This is a DataSource driver for Structures_DataGrid using arrays. It is a
base package for some other DataSource drivers like CSV or XML.
Comment 1 Jason Tibbitts 2006-12-02 19:45:32 UTC 
The by now standard rpmlint complaints:
   W: php-pear-Structures-DataGrid-DataSource-Array no-documentation
   W: php-pear-Structures-DataGrid-DataSource-Array filename-too-long-for-joliet
php-pear-Structures-DataGrid-DataSource-Array-0.1.0-1.fc7.noarch.rpm

There's really just a single 4K file here; not much to review, really.

* source files match upstream:
   9f9a76d291ee8d99134c71173bb84bdb  Structures_DataGrid_DataSource_Array-0.1.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(Structures_DataGrid_DataSource_Array) = 0.1.0
   php-pear-Structures-DataGrid-DataSource-Array = 0.1.0-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
   php-pear(Structures_DataGrid)
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (pear module installation)
* code, not content.

APPROVED
Comment 2 Jason Tibbitts 2006-12-02 20:15:57 UTC 
I must be slipping.  Of course I meant

O rpmlint output is OK.
Comment 3 Christopher Stone 2006-12-02 20:58:35 UTC 
Thanks for the review. :)
Comment 4 Christopher Stone 2007-05-05 23:52:03 UTC 
Package Change Request
======================
Package Name: php-pear-Structures-DataGrid-DaataSource-Array
New Branches: EL-5
Comment 5 Dennis Gilmore 2007-05-06 05:31:46 UTC 
EPEL done
Comment 6 Christopher Stone 2007-05-06 21:57:32 UTC 
It appears this did not get branched correctly, I noticed a typo in the name
from the original request, it should be:

Package Change Request
======================
Package Name: php-pear-Structures-DataGrid-DataSource-Array
New Branches: EL-5

I apologize if this is what caused the problem.
Note You need to log in before you can comment on or make changes to this bug.