Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 213192 - Review Request: python-nltk_lite - Natural Language Toolkit
Summary: Review Request: python-nltk_lite - Natural Language Toolkit
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
: 177619 (view as bug list)
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-10-31 04:28 UTC by Michel Alexandre Salim
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-13 05:28:57 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Michel Alexandre Salim 2006-10-31 04:28:26 UTC 
Spec URL: http://hircus.org/fedora/python-nltk_lite/python-nltk_lite.spec
SRPM URL: http://hircus.org/fedora/python-nltk_lite/python-nltk_lite-0.6.6-1.src.rpm
Description:
NLTK is a Python package that simplifies the construction of programs
that process natural language; and defines standard interfaces between
the different components of an NLP system.  It was designed primarily
to help teach graduate and undergraduate students about computational
linguistics; but it is also useful as a framework for implementing
research projects.

Note: the previous NLTK package in FE has been discontinued upstream; python-nltk_lite is the replacement.

http://fedoraproject.org/wiki/PackagingDrafts/ProvidesObsoletes

According to the (provisional?) guideline this package thus Obsoletes: python-nltk <= 1.4.4-2%{dist}, the latest released across all FE branches, but does not Provides: python-nltk. rpmlint will thus throw an error on the binary RPM produced.

The spec is slightly modified from the one for python-nltk, taking advantage of FE4+'s bytecode compiling script for Python, and to not exclude *.pyo files.
Comment 1 Michel Alexandre Salim 2006-11-09 16:04:25 UTC 
*** Bug 177619 has been marked as a duplicate of this bug. ***
Comment 2 José Matos 2006-11-10 23:41:39 UTC 
Review for release 1:
* RPM name is OK
* Source nltk_lite-0.6.6.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* License is correct and acceptable for Fedora (GPL)
* Package is code not content
* Package follows guidelines
* Spec file is readable and written in American English
* Requires and Build Requires are the necessary

One small question though, why do you set CFLAGS since this package is noarch?

Regardless this is not a blocker and this package is Approved.
Comment 3 Michel Alexandre Salim 2006-11-13 05:28:57 UTC 
CFLAGS removed. Thanks for noticing - I guess I got it from the default Python
template and forgot to remove it.
Note You need to log in before you can comment on or make changes to this bug.