Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 213595 (tbcload) - Review Request: tbcload - Tcl bytecode loader
Summary: Review Request: tbcload - Tcl bytecode loader
Keywords:
Status: CLOSED NEXTRELEASE
Alias: tbcload
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul F. Johnson
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT tclcompiler tclchecker tcldebugger
TreeView+ depends on / blocked
 
Reported: 2006-11-02 06:17 UTC by Wart
Modified: 2009-01-28 05:50 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-08 01:22:00 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Wart 2006-11-02 06:17:25 UTC 
Spec URL: http://www.kobold.org/~wart/fedora/tbcload.spec
SRPM URL: http://www.kobold.org/~wart/fedora/tbcload-1.4-1.20061030cvs.src.rpm
Description: 
Bytecode loader for precompiled Tcl files.

Note:  Upstream has not released official tarballs of this package.  When I asked about it, they said they did not have time for generating official releases and that CVS snapshots should be used instead.
Comment 1 Wart 2006-11-02 21:23:12 UTC 
Added the missing license file:

http://www.kobold.org/~wart/fedora/tbcload.spec
http://www.kobold.org/~wart/fedora/tbcload-1.4-2.20061030cvs.src.rpm
Comment 2 Paul F. Johnson 2006-11-07 23:54:58 UTC 
rpmlint warnings/errors

rpm : incoherent version number
devel : no docs
debug & srpm : clean

builds fine in mock

Review

Spec file clean, uses constant macros, in US English
pkgconfig not required for devel package
no md5sum as it's a cvs checkout
cvs naming correct
contains documentation
nothing missing from rpm requires
uses smp_mflags
Permissions fine
no ownership problems

As long as you fix the version number, I'll let it through

APPROVED
Comment 3 Wart 2006-11-08 00:40:25 UTC 
Thanks for the review!  Yes, I had a typo in the %changelog for the version number.

Here is the spec/srpm files with the fix:

http://www.kobold.org/~wart/fedora/tbcload-1.4-3.20061030cvs.src.rpm
http://www.kobold.org/~wart/fedora/tbcload.spec

Since this is already FE-ACCEPTED, I'll import this fixed SRPM.
Comment 4 Wart 2006-11-08 01:22:00 UTC 
Imported and built.  Closing.

Thanks again!
Comment 5 Wart 2009-01-28 00:58:59 UTC 
Package Change Request
======================
Package Name: tbcload
New Branches: EL-4 EL-5
Owners: wart
Comment 6 Kevin Fenzi 2009-01-28 05:50:38 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.