Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== Issues =====

- The Python interpreter must be invoked using the %{python3} macro; change

    xvfb-run -a python3 -m pytest -k 'not plot'

  to

    xvfb-run -a %{python3} -m pytest -k 'not plot'

  https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_mandatory_macros

  While it requires you to use a “private” macro with double leading
  underscores, something like this would work nicely too:

    %global __pytest %{_bindir}/xvfb-run -a %{_bindir}/pytest
    %pytest -k 'not plot'

- There are linters and coverage analysis tools, which we normally patch out
  (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters),
  in the runtime dependencies (“install_requires”). Considering that this is
  not a testing or code analysis package, this is very strange and seems to be
  a mistake. None of these packages are imported by the library.

  Consider sending a PR upstream to move these to the existing “test” extra, and
  applying it downstream as a patch.

        "coverage>=5.5",
        "pre-commit>=2.17.0",
        "pylint>=2.7.2",
        "pytest>=6.2.2",

- While it is harmless to write “%pyproject_buildrequires -r”, this is now the
  default and is equivalent to just “%pyproject_buildrequires”.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* Apache License". 525 files have unknown license.
     Detailed output of licensecheck in /home/ben/Downloads/2150221-python-
     opytimizer/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.

     $ rpm -qL -p results/python3-opytimizer-3.1.2-1.fc38.noarch.rpm
     /usr/lib/python3.11/site-packages/opytimizer-3.1.2.dist-info/LICENSE

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python

     (except as noted)

[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).

     Linters etc. in install_requires; see issues above.

[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-opytimizer
[x]: Package functions as described.

     (tests pass)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.

     koji build --scratch f38 srpm/python-opytimizer-3.1.2-1.fc37.src.rpm --arch-override='x86_64 i686 ppc64le s390x aarch64'
     https://koji.fedoraproject.org/koji/taskinfo?taskID=95760470

[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-opytimizer-3.1.2-1.fc38.noarch.rpm
          python-opytimizer-doc-3.1.2-1.fc38.noarch.rpm
          python-opytimizer-3.1.2-1.fc38.src.rpm
=============================================== rpmlint session starts ===============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpni6mo0ni')]
checks: 31, packages: 3

python-opytimizer.spec: W: patch-not-applied Patch0: 33.patch
  (spurious: rpmlint does not understand %forgeautosetup)
python-opytimizer-doc.noarch: W: description-shorter-than-summary
================ 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.0 s ================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

python-opytimizer-doc.noarch: W: description-shorter-than-summary
 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s 



Source checksums
----------------
https://github.com/gugarosa/opytimizer/archive/v3.1.2/opytimizer-3.1.2.tar.gz :
  CHECKSUM(SHA256) this package     : b0760404af04762193aa1be30f8c4e38bf0cbda2359e17ff7141215554165097
  CHECKSUM(SHA256) upstream package : b0760404af04762193aa1be30f8c4e38bf0cbda2359e17ff7141215554165097


Requires
--------
python3-opytimizer (rpmlib, GLIBC filtered):
    python(abi)
    python3.11dist(coverage)
    python3.11dist(dill)
    python3.11dist(matplotlib)
    python3.11dist(networkx)
    python3.11dist(numpy)
    python3.11dist(opytimark)
    python3.11dist(pre-commit)
    python3.11dist(pylint)
    python3.11dist(pytest)
    python3.11dist(tqdm)

python-opytimizer-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-opytimizer:
    python-opytimizer
    python3-opytimizer
    python3.11-opytimizer
    python3.11dist(opytimizer)
    python3dist(opytimizer)

python-opytimizer-doc:
    python-opytimizer-doc



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2150221
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: Java, fonts, SugarActivity, Perl, Ocaml, Haskell, C/C++, PHP, R
Disabled flags: EPEL7, EPEL7, DISTTAG, BATCH, EXARCH

Thanks, Ben.

New files are up:

SPEC:https://raw.githubusercontent.com/firefly-cpp/rpm-reviews/main/python-opytimizer.spec

SRPM: https://github.com/firefly-cpp/rpm-reviews/raw/main/python-opytimizer-3.1.2-1.fc37.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5202315
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-2150221-python-opytimizer/fedora-rawhide-x86_64/05202315-python-opytimizer/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

I’m sorry it’s taken so long to get back to this.

The changes look good:

--- srpm-unpacked/python-opytimizer.spec	2022-12-01 13:30:05.000000000 -0500
+++ 2150221-python-opytimizer/srpm-unpacked/python-opytimizer.spec	2023-01-05 12:20:23.000000000 -0500
@@ -25,6 +25,10 @@
 # PR: https://github.com/gugarosa/opytimizer/pull/33
 Patch:          33.patch
 
+# Move development dependencies out from the main dependencies
+# PR: https://github.com/gugarosa/opytimizer/pull/34
+Patch:          34.patch
+
 %description
 %{desc}
 
@@ -65,7 +69,7 @@
 %forgeautosetup -p1
 
 %generate_buildrequires
-%pyproject_buildrequires -r
+%pyproject_buildrequires
 
 %build
 %pyproject_wheel
@@ -83,7 +87,7 @@
 
 # despite the use of xvfb, several plots are shown
 %if %{with tests}
-xvfb-run -a python3 -m pytest -k 'not plot'
+xvfb-run -a %{python3} -m pytest -k 'not plot'
 %endif
 
 %files -n python3-opytimizer -f %{pyproject_files}

And the patch looks reasonable:

https://github.com/gugarosa/opytimizer/pull/34/files

So does the rpmlint output:

Checking: python3-opytimizer-3.1.2-1.fc38.noarch.rpm
          python-opytimizer-doc-3.1.2-1.fc38.noarch.rpm
          python-opytimizer-3.1.2-1.fc38.src.rpm
=============================================== rpmlint session starts ===============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpn_fz2646')]
checks: 31, packages: 3

python-opytimizer.spec: W: patch-not-applied Patch0: 34.patch
python-opytimizer-doc.noarch: W: description-shorter-than-summary
================ 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s ================

The first warning is because rpmlint does not understand %forgeautosetup, and the second is not a real problem in this case.

I’m therefore going to skip re-posting the full review template. The package is APPROVED.

Thanks, Ben!

The review bug has to be in ASSIGNED state when you request the repo.

https://pagure.io/releng/fedora-scm-requests/issue/50389#comment-835213

I cycled all the states on the bug as if it were a new review. Try again?

Maybe there is a bug in the new SCM request automation.

It is still not working as expected.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-opytimizer

FEDORA-2023-6b23d2a748 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6b23d2a748

FEDORA-2023-6b23d2a748 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6b23d2a748`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6b23d2a748

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-6b23d2a748 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.