Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2154979 - python-smbpasswd fails to build with Python 3.12: ModuleNotFoundError: No module named 'distutils'
Summary: python-smbpasswd fails to build with Python 3.12: ModuleNotFoundError: No mo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-smbpasswd
Version: 39
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Michal Ambroz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
: 2220510 (view as bug list)
Depends On:
Blocks: F39FTBFS F39FailsToInstall F40FTBFS PYTHON3.12 F39FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2022-12-19 18:09 UTC by Tomáš Hrnčiar
Modified: 2023-10-14 01:31 UTC (History)
6 users (show)

Fixed In Version: python-smbpasswd-1.0.2-15.fc39 python-smbpasswd-1.0.2-15.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-07 03:23:46 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Tomáš Hrnčiar 2022-12-19 18:09:19 UTC 
python-smbpasswd fails to build with Python 3.12.0a3.

+ /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -sP'
Traceback (most recent call last):
  File "/builddir/build/BUILD/py-smbpasswd-1.0.2/setup.py", line 11, in <module>
    from distutils.core import setup, Extension
ModuleNotFoundError: No module named 'distutils'

Remove the distutils package. It was deprecated in Python 3.10 by PEP 632 “Deprecate distutils module”. For projects still using distutils and cannot be updated to something else, the setuptools project can be installed: it still provides distutils. (Contributed by Victor Stinner in gh-92584.)

If your package is listed in [0], you may workaround this issue by BuildRequiring python-setuptools, note that adding such BuildRequires might however hide some transitive dependency problem, if the distutils import comes from a dependency.
Cooperation with upstream is recommended. Additional context [1].

[0] https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/message/6BHNAWHE7M5VY3YQVJLOYHLY4M7KIFFN/

[1] https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/N6ITYHLRWIDNYNXGPYG2ZHF3ZLQWZN7L/

https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05129869-python-smbpasswd/

For all our attempts to build python-smbpasswd with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-smbpasswd/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.
Comment 1 Ben Cotton 2023-02-07 15:11:49 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 2 Miro Hrončok 2023-09-21 08:04:16 UTC 
*** Bug 2220510 has been marked as a duplicate of this bug. ***
Comment 3 Miro Hrončok 2023-09-21 08:10:00 UTC 
Michal, I see you assigned this bugzilla 8 months ago. Have you made any progress?

The package fails to install and fails to build. Fedora 39 Beta was just released. Is it probable that this will be fixed (or worked around) in time for the Fedora 39 Final Freeze (2023-10-03)? If not, could you please consider retiring the package, so we can obsolete it and unblock clean upgrades to Fedora 39? A retired package can be reintroduced later during the life time of Fedora 39.
Comment 4 Miro Hrončok 2023-10-03 11:47:17 UTC 
Adding:

    BuildRequires:  python3-setuptools

Makes the package build, but it is very broken:

(Using the example from README.txt):

>>> import smbpasswd
>>> passwd = 'mypassword'
>>> print('LANMAN hash is', smbpasswd.lmhash(passwd))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats


This is also happening on Fedora 38. This package has been broken for a while and nobody seems to have noticed.
Comment 5 Miro Hrončok 2023-10-03 11:49:29 UTC 
Note that I have requested retirement via https://pagure.io/fesco/issue/3080

If you plan to fix this in time for Fedora Linux 39 final release, please let me know ASAP.
Comment 6 Fedora Update System 2023-10-05 00:44:43 UTC 
FEDORA-2023-8666d61708 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8666d61708
Comment 7 Michal Ambroz 2023-10-05 01:36:33 UTC 
Thanks Miro for testing. I have fixed the s# formatting for post 3.10
Comment 8 Fedora Update System 2023-10-05 01:45:18 UTC 
FEDORA-2023-d695a9bb67 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d695a9bb67
Comment 9 Fedora Update System 2023-10-05 01:45:19 UTC 
FEDORA-2023-a07fa5e33d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a07fa5e33d
Comment 10 Fedora Fails To Install 2023-10-05 15:49:26 UTC 
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 40.

Thanks for taking care of it!
Comment 11 Fedora Update System 2023-10-05 20:10:18 UTC 
FEDORA-2023-a07fa5e33d has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a07fa5e33d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a07fa5e33d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2023-10-06 02:53:48 UTC 
FEDORA-2023-d695a9bb67 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d695a9bb67`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d695a9bb67

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 13 Kamil Páral 2023-10-06 10:38:01 UTC 
Can be installed. Functionality not tested.
Comment 14 Adam Williamson 2023-10-06 19:19:37 UTC 
+4 in https://pagure.io/fedora-qa/blocker-review/issue/1379 , marking accepted.
Comment 15 Fedora Update System 2023-10-07 03:23:46 UTC 
FEDORA-2023-a07fa5e33d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 16 Fedora Update System 2023-10-14 01:31:09 UTC 
FEDORA-2023-d695a9bb67 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.