Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 215563 - Review Request: aquamarine - Themeable window decorator and compositing manager for Beryl
Summary: Review Request: aquamarine - Themeable window decorator and compositing manag...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Michał Bentkowski
QA Contact: Fedora Package Reviews List
Depends On: 209259
TreeView+ depends on / blocked
Reported: 2006-11-14 17:20 UTC by Jarod Wilson
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-11-21 20:55:17 UTC
Type: ---

Attachments (Terms of Use)

Description Jarod Wilson 2006-11-14 17:20:05 UTC
Spec URL:
Aquamarine is themeable window decorator and compositing
manager for Beryl. Launch Theme Manager from
beryl-manager to change themes. Aquamarine is intended
for use with KDE.

Depends on beryl-core, submitted for FE-review under bug 209259.

Comment 1 Michał Bentkowski 2006-11-16 19:35:57 UTC
I think this package may be approved, the only problem is a lack of license file
so I'm not able to check if aquamarine is really GPL ;)
I'll do a full review later.

Comment 2 Michał Bentkowski 2006-11-16 19:51:57 UTC
MUST items:
 * rpmlint output:
W: aquamarine no-documentation
 (no documentation provided by upstream)
 * package is named well
 * spec file name is good
 * package meets Packaging Guidelines
?* package is licensed with an GPL open-source compatible license
?* License field in spec file matches actual license 
 * license file isn't included in %doc
 * no upstream release, unable to check md5
 * package successfully compiles on x86_64
 * BuildRequires listed well (mock builds successfully)
 * no locales
 * no need to %post and %postun sections
 * not relocatable
 * no duplicates in %files
 * every %files section includes %defattr
 * proper %clean section
 * macros used well

License is not included in a package, I couldn't find any reliable site
to check its license. Thus, if you show me a place where the license's written,
I'll be happy to approve this package :)

Comment 3 Jarod Wilson 2006-11-16 23:36:58 UTC
Only place I'm seeing anything about the license is currently in the source code
itself (src/aquamarine.cpp):

 *  Aquamarine the KDE window decorator
 *  Copyright (c) 2006 Dennis Kasprzyk <onestone>
 *  Copyright (c) 2006 Volker Krause <vkrause>
 *  Uses code of:
 *      Emerald window decorator (
 *      KWin window manager (
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  GNU General Public License for more details.
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

So it *is* GPL, they just haven't got around to putting evidence of that
somewhere sensible yet. :)

Also, there's a new build that has trimmed down BR (needs beryl-core-devel >=

Comment 4 Mamoru TASAKA 2006-11-17 17:45:30 UTC
mock build suceeds on FC-devel i386.

* BuildRequires: qt, kdelibs
  This is not needed to be written as libraries' dependency
  on this package automatically requires them ( and

Comment 5 Jarod Wilson 2006-11-17 18:52:34 UTC
New build, removes Requires: on qt and kdelibs, relies on auto-gen'd lib deps.

Comment 6 Michał Bentkowski 2006-11-17 21:52:19 UTC

Note You need to log in before you can comment on or make changes to this bug.