I cannot read your spec/srpm. Is piedmont.homelinux.org alive?

yes it looks like the piedmont.homelinux.org server is down again.

Brian email me the spec and src.rpm and I can host them for you.

-jef

Here you go, these urls are live.

http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine-0.3.16-1.src.rpm
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine.spec

Uhm looks like they bumped up to 0.3.18 in the meantime.

Would you like me to spin up an updated srpm and spec for 0.3.18 and place them
on the website for you?

-jef

URL updated
http://jspaleta.thecodergeek.com/Fedora%20SRPMS/telepathy-stream-engine/telepathy-stream-engine-0.3.18-1.src.rpm

I will be starting the formal review of 0.3.18 srpm tonite as time allows.

It looks good. Here is the formal review.
I'm going to start a clock on this, and if noone brings up any blockers I'll
approve tomorrow evening.

-jef

GOOD:
*Built in mock on i386 against fedora-development
*rpmlint runs cleanly against it
*follows naming guidelines
*licnese is LGPL and spec tag matches
*COPYING file in %doc
*spec in US/english and legible
*Include source matches upstream md5sum
52c0b48905f11cac71df1f8560c8f4d7  telepathy-stream-engine-0.3.18.tar.gz

*buildrequires look good
*no locales to worry about
*no shared libraries
*not relocatable
*does not create any unowned directories. Package requires   
  libdbus-1.so.3 which is provided by dbus which owns 
  %{_datadir}/dbus-1/services/
*no duplicates in %files
*file permissions seem fine
*install and clean sections look good
*macro use is consistent
*docs is good
*no -devel subpackage
*no la files
*not a gui, no desktop file needed
*appears to meet all packaging guidelines

Well, 
* please check if the following is what you expect.
---------------------------------------------------
checking for pic2plot... no
checking for gs... no
checking for convert... no
configure: WARNING: Imagemagick not found, drawing sequence diagrams will be
disabled.
configure: WARNING: Ghostscript not found, drawing sequence diagrams will be
disabled.
configure: WARNING: GNU plotutils not found, drawing sequence diagrams will be
disabled.
----------------------------------------------------
Note: all of them are available in Fedora Core/Extras and
a people who has already installed them beforehand may create
different binary rpm of telepathy-stream-engine.

Yes, this was on purpose since the sequence diagrams generation support isn't
complete yet.

Okay, then this package can be approved IMO.

(In reply to comment #8)
> Yes, this was on purpose since the sequence diagrams generation support isn't
> complete yet.

Does the configure script let you explicitly disable imagemagik,gs, and
plotutils support?  It would be best if these features were explicitly disabled
so we can get consistent rebuilds of the srpm even in build environments where
these exist.
I'm not sure this should count as a blocker or not, but I think Mamoru has a
point concerning binary reproducibility.

-jef

(In reply to comment #10)
> Does the configure script let you explicitly disable imagemagik,gs, and
> plotutils support?  It would be best if these features were explicitly disabled
> so we can get consistent rebuilds of the srpm even in build environments where
> these exist.

I believe there is a '--enable-sequence-diagrams=no' option we can add to
disable the building of this.

Approved,
just add --enable-sequencec-diagrams=no  to the %configure before you build.

-jef

Jef, thanks for the review.

Package Change Request
======================
Package Name: telepathy-stream-engine
New Branches: OLPC2
Updated Fedora Owners: gdesmott,bpepple

CVS done.