Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2184091 - LLVM 16 pull Into Fedora 38 (FreezeException)
Summary: LLVM 16 pull Into Fedora 38 (FreezeException)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: llvm
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom Stellard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
Depends On:
Blocks: F38FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2023-04-03 15:50 UTC by František Zatloukal
Modified: 2023-04-11 23:07 UTC (History)
16 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-11 23:07:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description František Zatloukal 2023-04-03 15:50:31 UTC
LLVM 16 is an accepted Fedora 38 change: https://fedoraproject.org/wiki/Changes/LLVM-16

We can consider pulling it in under FE, this would mean pulling the builds in from the following side-tag: f38-build-side-65262 ( https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=65262&order=-build_id&latest=1 ).

Comment 1 Adam Williamson 2023-04-03 16:36:13 UTC
Why wasn't this done well before Final freeze? Changes are supposed to be 'code complete' by *Beta*.

Comment 2 Tom Stellard 2023-04-03 18:15:49 UTC
For each Fedora release, we always target the final freeze to get all of our builds done.  This is necessary due to how the upstream release schedule aligns with Fedora's and because the upstream API does not finalize until the final release (making packaging earlier release candidates difficult).

We have been building and testing release candidates in COPR for the last two months, getting the final builds into Fedora 38 is just the last step of a longer process.  Right now we have most of the builds done and there are just 2 or 3 left to do.

The contingency deadline of the 'Final Freeze' was documented in the change proposal: https://fedoraproject.org/wiki/Changes/LLVM-16 and we re-iterated our Final Freeze goal to FESCO in a recent status update: https://pagure.io/fesco/issue/2958#comment-843760

We do our best to get the builds done on time, but occasionally we miss and need a freeze exception.  The last time this happened was for Fedora 35: https://bugzilla.redhat.com/show_bug.cgi?id=2072077

Comment 3 Adam Williamson 2023-04-03 20:11:40 UTC
That time, the update had already been in updates-testing for a while. This time there is nothing in updates-testing.

It's just not an appropriate development process to be landing major changes after the final freeze. That's not how we build stuff. I appreciate that there is a schedule problem here, but the appropriate solution for that is not "let's land major new versions of stuff during Fedora final freeze". There needs to be a better solution, like llvm stabilizing its API during the pre-release phase so we can land a pre-release earlier in the cycle and only have to bump to the final release later.

Comment 4 Geoffrey Marr 2023-04-03 20:35:04 UTC
Discussed during the 2023-04-03 blocker review meeting: [0]

The decision to delay the classification of this as a blocker bug was made as we do not have a clear vote on this (we are at +2 / -3 for a total of -1), so we will punt it. Note: this is effectively close to a rejection, as we are very unlikely to accept this later if we don't accept it now.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2023-04-03/f38-blocker-review.2023-04-03-16.01.txt

Comment 5 Tom Stellard 2023-04-03 20:59:00 UTC
(In reply to Geoffrey Marr from comment #4)
> Discussed during the 2023-04-03 blocker review meeting: [0]
> 
> The decision to delay the classification of this as a blocker bug was made
> as we do not have a clear vote on this (we are at +2 / -3 for a total of
> -1), so we will punt it. Note: this is effectively close to a rejection, as
> we are very unlikely to accept this later if we don't accept it now.
> 
> [0]
> https://meetbot.fedoraproject.org/fedora-blocker-review/2023-04-03/f38-
> blocker-review.2023-04-03-16.01.txt

When is the next meeting?

Comment 6 Tom Stellard 2023-04-04 01:00:46 UTC
(In reply to Adam Williamson from comment #3)
> That time, the update had already been in updates-testing for a while. This
> time there is nothing in updates-testing.
> 
> It's just not an appropriate development process to be landing major changes
> after the final freeze. That's not how we build stuff. I appreciate that
> there is a schedule problem here, but the appropriate solution for that is
> not "let's land major new versions of stuff during Fedora final freeze".

I'm not sure this comment is really fair.  Our solution involved landing the changes
before the final freeze as documented in the change proposal.  We weren't originally
planning to push the changes in after the freeze.  It just turned out to be more work
than expected so we missed the deadline.

> There needs to be a better solution, like llvm stabilizing its API during
> the pre-release phase so we can land a pre-release earlier in the cycle and
> only have to bump to the final release later.

We used to do it this way, but it turned out to be way too difficult to coordinate all
the rebuilds of the dependent packages.  That is why we switched to our current method
where we do all the builds and testing for the pre-releases in COPR and then do the final
builds in koji once we feel like everything is ready.

At the end of each release we look at our process and try to find ways to improve it,
so if anyone has suggestions for how to improve what we do, we are happy to listen.

Comment 7 Adam Williamson 2023-04-04 06:17:30 UTC
> When is the next meeting?

Next Monday. Async voting is possible in the pagure ticket - https://pagure.io/fedora-qa/blocker-review/issue/1136 .

>> I appreciate that
>> there is a schedule problem here, but the appropriate solution for that is
>> not "let's land major new versions of stuff during Fedora final freeze".

> I'm not sure this comment is really fair.  Our solution involved landing the changes
> before the final freeze as documented in the change proposal.  We weren't originally
> planning to push the changes in after the freeze.  It just turned out to be more work
> than expected so we missed the deadline.

I understand the behind-the-scenes, but what it *boils down to* is trying to land a new major version during the final freeze. The way the Change process is supposed to work is that if you miss the deadline, the Change gets put off to the next release. The way the freeze policy works is we don't change stuff during freezes unless there's a really good reason to.

Comment 8 Tom Stellard 2023-04-04 13:46:22 UTC
(In reply to Adam Williamson from comment #7)
> > When is the next meeting?
> 
> Next Monday. Async voting is possible in the pagure ticket -
> https://pagure.io/fedora-qa/blocker-review/issue/1136 .
> 

OK, I won't be able to attend the next meeting. Where is the best place for me to leave feedback, here or on the pagure  ticket?

Comment 9 Adam Williamson 2023-04-04 16:08:50 UTC
Either works. Theoretically the idea is that discussion of the bug per se goes here and discussion of blocker/FE-ness goes in the ticket, but when the bug is purely a blocker/FE bureaucracy bug, obviously the distinction barely exists :)

Comment 10 Fedora Update System 2023-04-05 08:27:34 UTC
FEDORA-2023-3a602914f6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a602914f6

Comment 11 Vitaly 2023-04-05 12:11:11 UTC
Please include iwyu-0.20-1.fc38 build to LLVM 16 Bodhi update. I built and tagged it to this side tag.

Comment 12 Fedora Update System 2023-04-05 17:33:41 UTC
FEDORA-2023-3a602914f6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a602914f6

Comment 13 Tulio Magno Quites Machado Filho 2023-04-05 17:44:30 UTC
Would it be possible to extend this FE to this Bodhi update too? https://bodhi.fedoraproject.org/updates/FEDORA-2023-07c0c553a1
This updates qt-creator, removing an unnecessary dependency that previous package versions had on LLVM packages.

Comment 14 František Zatloukal 2023-04-05 18:11:16 UTC
(In reply to Tulio Magno Quites Machado Filho from comment #13)
> Would it be possible to extend this FE to this Bodhi update too?
> https://bodhi.fedoraproject.org/updates/FEDORA-2023-07c0c553a1
> This updates qt-creator, removing an unnecessary dependency that previous
> package versions had on LLVM packages.

I'd probably propose that as a separate FE, but it should be possible to mark that update as fixing this bug too, afaik.

Comment 15 Fedora Update System 2023-04-06 01:47:43 UTC
FEDORA-2023-3a602914f6 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a602914f6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Adam Williamson 2023-04-07 15:59:28 UTC
+5 in https://pagure.io/fedora-qa/blocker-review/issue/1136 , marking accepted.

Comment 17 Fedora Update System 2023-04-11 18:36:37 UTC
FEDORA-2023-3a602914f6 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a602914f6

Comment 18 Fedora Update System 2023-04-11 22:14:21 UTC
FEDORA-2023-3a602914f6 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a602914f6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2023-04-11 22:33:32 UTC
FEDORA-2023-3a602914f6 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.