Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 218574 - Review Request: perl-Net-SNPP - Perl modules for the Simple Network Pager Protocol
Summary: Review Request: perl-Net-SNPP - Perl modules for the Simple Network Pager Pro...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-06 04:38 UTC by Jeffrey C. Ollie
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-07 13:20:13 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jeffrey C. Ollie 2006-12-06 04:38:46 UTC 
Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/perl-Net-SNPP-1.17-1.fc6.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/perl-Net-SNPP-1.17-1.fc6.src.rpm
Description:

Perl client and server modules for the Simple Network Pager Protocol,
as described in RFC 1861.

(Annoyed Grunt) Misspelled modules in the summary - will fix upon import or the next package rev, whichever comes first...
Comment 1 Parag AN(पराग) 2006-12-06 15:33:52 UTC 
preliminary review
rpmlint is silent
ok summary can be changed at time of importing a package.
will do Full review tomorrow.
Comment 2 Parag AN(पराग) 2006-12-07 07:23:03 UTC 
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMS.
+ source files match upstream.
18f61a774906cd27ca14dcbf311e6bf0  Net-SNPP-1.17.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ %check used and its result in mock build is
 All tests successful.
 Files=2, Tests=16,  0 wallclock secs ( 0.12 cusr +  0.03 csys =  0.15 CPU)
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
APPROVED.
Comment 3 Jeffrey C. Ollie 2006-12-07 13:20:13 UTC 
Thanks for the review!  Fixed the summary, imported and built for development.
Note You need to log in before you can comment on or make changes to this bug.