Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2189641 - Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang
Summary: Review Request: golang-github-pin-tftp-3 - TFTP server and client library for...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR 2133290
TreeView+ depends on / blocked
 
Reported: 2023-04-25 18:59 UTC by Maverick Kaung
Modified: 2023-07-09 19:19 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-26 18:31:31 UTC
Type: ---
Embargoed:
daron439: fedora-review+

Attachments (Terms of Use)

Description Maverick Kaung 2023-04-25 18:59:15 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05849303-golang-github-pin-tftp-3/golang-github-pin-tftp.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05849303-golang-github-pin-tftp-3/golang-github-pin-tftp-3-3.0.0-1.fc38.src.rpm
Description: TFTP server and client library for Golang
Fedora Account System Username: mavjs

Here is a build in copr: https://copr.fedorainfracloud.org/coprs/mavjs/package-reviews/build/5849303/

This package is required to update gobuster to latest stable version: v3.5.0
Current gobuster package version in Fedora is currently at: v3.1.0

Note: I am not a fedora packager yet and will require a sponsor.
Comment 1 Pavel Solovev 2023-04-25 21:06:09 UTC 
> golang-github-pin-tftp.spec
The filename of spec MUST match the name of the package. Rename to golang-github-pin-tftp-3.spec

> %global forgeurl1	https://github.com/pin/tftp
Isn't really needed, it is deduced automatically
Comment 2 Maverick Kaung 2023-04-26 16:43:38 UTC 
(In reply to Pavel Solovev from comment #1)
> > golang-github-pin-tftp.spec
> The filename of spec MUST match the name of the package. Rename to
> golang-github-pin-tftp-3.spec

Done. See new build link below.

> > %global forgeurl1	https://github.com/pin/tftp
> Isn't really needed, it is deduced automatically

This was removed as well.

Note: I deleted the previous builds and therefore, here are the new links:

SPEC URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05852501-golang-github-pin-tftp-3/golang-github-pin-tftp-3.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fedora-38-x86_64/05852501-golang-github-pin-tftp-3/golang-github-pin-tftp-3-3.0.0-1.fc38.src.rpm
COPR URL: https://copr.fedorainfracloud.org/coprs/mavjs/package-reviews/build/5852501/
Comment 3 Pavel Solovev 2023-04-26 17:01:23 UTC 
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] The latest version is packaged.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!
Comment 4 Pavel Solovev 2023-04-26 17:49:59 UTC 
Ah, and the last thing - on import, remove the `-f` flag from %gometa, gobuster is still
built for i386.
Comment 5 Maverick Kaung 2023-04-26 18:02:42 UTC 
(In reply to Pavel Solovev from comment #4)
> Ah, and the last thing - on import, remove the `-f` flag from %gometa,
> gobuster is still
> built for i386.

Will do. Thanks for the review.
Comment 6 Debarshi Ray 2023-05-26 13:30:59 UTC 
Maverick, I see that you are already a member of the 'packager' group:
https://accounts.fedoraproject.org/user/mavjs/

Do you still need a sponsor?
Comment 7 Maverick Kaung 2023-05-26 15:27:38 UTC 
(In reply to Debarshi Ray from comment #6)
> Maverick, I see that you are already a member of the 'packager' group:
> https://accounts.fedoraproject.org/user/mavjs/
> 
> Do you still need a sponsor?

Hey rishi, thanks for reaching out (via email as well).
I got sponsored by nirik (Kevin). I just need to follow up with the steps to continue.

-Maverick
Comment 8 Fedora Admin user for bugzilla script actions 2023-05-26 16:23:59 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pin-tftp-3
Comment 9 Fedora Update System 2023-05-26 18:29:06 UTC 
FEDORA-2023-b80d36465b has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b80d36465b
Comment 10 Fedora Update System 2023-05-26 18:31:31 UTC 
FEDORA-2023-b80d36465b has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 11 Michal Ambroz 2023-07-09 19:19:31 UTC 
Hello,
this package is needed for the gobuster 3.5.0 - https://src.fedoraproject.org/rpms/gobuster
Please would you mind building the golang-github-pin-tftp-3 also for the F38 F37 ?
Thank you
Michal Ambroz
Note You need to log in before you can comment on or make changes to this bug.