Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 219869 (perldap) - Review Request: perl-Mozilla-LDAP
Summary: Review Request: perl-Mozilla-LDAP
Alias: perldap
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact: Fedora Package Reviews List
Depends On: mozldap
TreeView+ depends on / blocked
Reported: 2006-12-15 20:02 UTC by Rich Megginson
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-01-10 23:57:50 UTC
Type: ---

Attachments (Terms of Use)
updated spec file (deleted)
2007-01-10 22:31 UTC, Dennis Gilmore
no flags Details

Description Rich Megginson 2006-12-15 20:02:37 UTC
This perl module is a wrapper around the Mozilla LDAP C SDK.  This package is
necessary for Fedora Directory Server (not for core server functionality, but
for management scripts) and other applications that require the use of the
Mozilla LDAP C SDK from perl applications.  The reason why we must use this
module and not the more common Net::LDAP module is because we require the use of
Mozilla NSS for crypto, and Net::LDAP uses openssl (via Net::SSLeay).


Comment 1 Dennis Gilmore 2007-01-09 21:34:59 UTC
a couple of notes

this builds and works fine on sparc  not sure why its ExclusiveArch i386 

the Requires on nss nspr and mozldap are unneccesary  rpm has the smarts to 
know that 

source needs to be a full url in spec file

please add disttag to the release

rpmlint says
E: perl-Mozilla-LDAP useless-explicit-provides perl(Mozilla::LDAP::Entry)
E: perl-Mozilla-LDAP 
non-standard-executable-perm /usr/lib/perl5/vendor_perl/5.8.8/sparc-linux-thread-multi/auto/Mozilla/LDAP/API/ 
E: perl-Mozilla-LDAP 
zero-length /usr/lib/perl5/vendor_perl/5.8.8/sparc-linux-thread-multi/auto/Mozilla/LDAP/API/

Comment 3 Dennis Gilmore 2007-01-10 22:31:30 UTC
Created attachment 145292 [details]
updated spec file

Comment 4 Dennis Gilmore 2007-01-10 22:32:17 UTC
Two small issues 
include  MPL-1.1.txt RELEASE  in %doc  and change the license field to MPL  as 
thats what it seems to be licensed under.

 package meets naming and packaging guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
 dist tag is present.
 build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 license is open source-compatible.   MPL License text included in package.
 source files match upstream:
    136f74d7649ada77cdf7657bb01a165f  perl-mozldap-1.5.tar.gz
    136f74d7649ada77cdf7657bb01a165f  ../SOURCES/perl-mozldap-1.5.tar.gz
 latest version is being packaged.
 BuildRequires are proper.
 package builds in mock ( on FC-6 ).
 rpmlint is silent.
 final provides and requires are sane:
 no shared libraries are present.
 package is not relocatable.
 owns the directories it creates.
 doesn't own any directories it shouldn't.
 no duplicates in %files.
 file permissions are appropriate.
 %clean is present.

 no scriptlets present.
 code, not content.
 documentation is small, so no -docs subpackage is necessary.
 %docs are not necessary for the proper functioning of the package.
 no headers.
 no pkgconfig files.
 no libtool .la droppings.
 not a GUI app.
 not a web app.

APPROVED using the attached spec file which fixes the issues 

Comment 6 Till Maas 2007-09-01 13:37:26 UTC
FE-ACCEPT should be blocked, not being depended on.

Note You need to log in before you can comment on or make changes to this bug.