Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 219979 (perl-Text-ASCIITable) - Review Request: perl-Text-ASCIITable - Create a nice formatted table using ASCII characters
Summary: Review Request: perl-Text-ASCIITable - Create a nice formatted table using AS...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Text-ASCIITable
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Text-ASCI...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-18 02:24 UTC by Chris Weyl
Modified: 2014-03-03 15:22 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-18 05:35:22 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2006-12-18 02:24:18 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Text-ASCIITable-0.18-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Text-ASCIITable.spec

Description:
Pretty nifty if you want to output dynamic text to your console or other
fixed-size-font displays, and at the same time it will display it in a nice
human-readable, or "cool" way.

Comment 1 Parag AN(पराग) 2006-12-18 05:23:11 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMS.
+ source files match upstream.
25fea1cef17be49a6da1d9b5267fba97  Text-ASCIITable-0.18.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ %check used
make test
+ ./Build test
t/01_default........ok
t/02_custom.........ok
t/03_options........ok
t/04_multiline......ok
t/05_wordwrap.......ok
t/06_htmlstrip......ok
t/07_aligning.......ok
t/08_heading........ok
t/09_ansistrip......ok
t/10_pages..........ok
t/11_overloading....ok
t/12_chaining.......ok
All tests successful.
Files=12, Tests=105,  1 wallclock secs ( 0.24 cusr +  0.07 csys =  0.31 CPU)

+ Provides: perl(Text::ASCIITable) = 0.18 perl(Text::ASCIITable::Wrap) = 0.2
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Followed perl packaging guidelines.
APPROVED.


Comment 2 Chris Weyl 2006-12-18 05:33:18 UTC
Imported and building for devel; branches requested.

Thanks for the review! :)

Comment 3 Chris Weyl 2006-12-18 05:33:38 UTC
Imported and building for devel; branches requested.

Thanks for the review! :)

Comment 4 Chris Weyl 2006-12-18 05:35:22 UTC
Slipped with the mouse there; should be to where things should be now :)

Comment 5 Lubomir Rintel 2009-05-07 07:11:55 UTC
Chris: I'll be very thankful if this was in EPEL-5 as well. Could you please
request an EL-5 branch (I'd gladly do that if you have a reason for not
maintaining it there).

Thanks!

Comment 6 Lubomir Rintel 2014-03-03 14:54:43 UTC
Package Change Request
======================
Package Name: perl-Text-ASCIITable
New Branches: epel7
Owners: lkundrak
InitialCC: perl-sig

The Fedora maintainer is unfortunately not maintaining EPEL packages:
http://fedoraproject.org/wiki/EPEL/ContributorStatusNo

Comment 7 Gwyn Ciesla 2014-03-03 15:22:04 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.