Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 220704 - Review Request: perl-GPS - Perl interface to a GPS receiver that implements the Garmin protocol
Summary: Review Request: perl-GPS - Perl interface to a GPS receiver that implements t...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-23 18:45 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-28 10:18:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-12-23 18:45:10 UTC
Spec URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-GPS.spec

SRPM URL:
ftp://perl.di.uminho.pt/pub/fedora/perl-GPS-0.15-1.src.rpm

Description:
This is a perl interface to a GPS receiver that implements the Garmin
protocol.

Comment 1 Dan Horák 2006-12-23 21:04:54 UTC
Review:
- no rpmlint output on any package
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license OK (GPL) and is included
- source matches upstream
	9569057d491c73cd597057de85472673  perl-GPS-0.15.tar.gz
	9569057d491c73cd597057de85472673  perl-GPS-0.15.tar.gz.1
- builds on i386/x86_64 (FC6 and devel)
- BuildRequires and Requires are correct
- no localized files
- has no shared lib
- owns created directories
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- no devel subpackage required, no pkgconfig file
- no .la libtool archives
- not a GUI application

APPROVED


Comment 2 Jose Pedro Oliveira 2006-12-28 10:18:25 UTC
Thanks for the review.

Package imported and built for FC-5, FC-6, and devel.


Note You need to log in before you can comment on or make changes to this bug.