Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 221010 - Review Request: librfid - Free Software RFID library
Summary: Review Request: librfid - Free Software RFID library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-12-30 11:25 UTC by kushaldas@gmail.com
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-12-31 08:21:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description kushaldas@gmail.com 2006-12-30 11:25:49 UTC
Spec URL: http://freeshell.in/~kushal/librfid.spec
SRPM URL: http://freeshell.in/~kushal/librfid-0.1.0-1.src.rpm
Description: librfid is a Free Software RFID library. It implements the PCD (reader) side protocol stack of ISO 14443 A, ISO 14443 B, ISO 15693, 
Mifare Ultralight and Mifare Classic. Support for iCODE and other 13.56MHz based transponders is planned.

Comment 1 Brian Pepple 2006-12-30 19:25:57 UTC
MD5Sum:
695e7f30f570a08407e42ed278ca2fe3  librfid-0.1.0.tar.bz2

Good:
* Source URL is canonical.
* License field in spec, match tarball license.
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros.
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners.
* Package name conforms to the Fedora Naming Guidelines.
* rpmlint produces no errors.
* Package builds in Mock fine.
* Package install and uninstalls cleanly on FC6.

Minor:
* I really don't think you need to add the same docs that are in the main
package to the devel package.  This isn't a blocker, but I would drop them.

+1 APPROVED

Comment 2 Michael Schwendt 2006-12-30 22:52:34 UTC
One thing to consider:

The %{_bindir}/send_script in the main package has a very generic
file name and bears the risk of creating a conflict with other
packages. The upstream authors are advised to choose a more unique
file name.


Comment 3 kushaldas@gmail.com 2006-12-31 08:18:44 UTC
(In reply to comment #1)
> Minor:
> * I really don't think you need to add the same docs that are in the main
> package to the devel package.  This isn't a blocker, but I would drop them.
> 
> +1 APPROVED
Done :)


Comment 4 kushaldas@gmail.com 2006-12-31 08:19:55 UTC
(In reply to comment #2)
> One thing to consider:
> 
> The %{_bindir}/send_script in the main package has a very generic
> file name and bears the risk of creating a conflict with other
> packages. The upstream authors are advised to choose a more unique
> file name.
> 

Will inform the upstream authors.

Comment 5 Harald Welte 2006-12-31 09:27:17 UTC
(I'm the upstream author):

The send_script program has been renamed into librfid_send_script in our SVN
tree. The next release of the library will reflact that change.

Thanks for letting us know.


Note You need to log in before you can comment on or make changes to this bug.