Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 2225745 - criu: FTBFS in Fedora rawhide/f39
Summary: criu: FTBFS in Fedora rawhide/f39
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: criu
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker F39FTBFS
TreeView+ depends on / blocked
 
Reported: 2023-07-25 17:23 UTC by Fedora Release Engineering
Modified: 2023-08-01 10:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-01 10:20:45 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
build.log (deleted)
2023-07-25 17:23 UTC, Fedora Release Engineering 		no flags Details
root.log (deleted)
2023-07-25 17:23 UTC, Fedora Release Engineering 		no flags Details
state.log (deleted)
2023-07-25 17:23 UTC, Fedora Release Engineering 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Fedora Package Sources criu pull-request 9 0 None None None 2023-07-31 17:44:16 UTC

Description Fedora Release Engineering 2023-07-25 17:23:14 UTC 
criu failed to build from source in Fedora rawhide/f39

https://koji.fedoraproject.org/koji/taskinfo?taskID=103565518


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
Please fix criu at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
criu will be orphaned. Before branching of Fedora 40,
criu will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
Comment 1 Fedora Release Engineering 2023-07-25 17:23:20 UTC 
Created attachment 1977710 [details]
build.log

file build.log too big, will only attach last 32768 bytes
Comment 2 Fedora Release Engineering 2023-07-25 17:23:25 UTC 
Created attachment 1977711 [details]
root.log

file root.log too big, will only attach last 32768 bytes
Comment 3 Fedora Release Engineering 2023-07-25 17:23:28 UTC 
Created attachment 1977712 [details]
state.log
Comment 4 Yaakov Selkowitz 2023-07-31 15:55:23 UTC 
Failure is specific to s390x:

In file included from compel/include/uapi/compel/asm/infect-types.h:7,
                 from compel/arch/s390/src/lib/infect.c:12:
compel/arch/s390/src/lib/infect.c: In function 'rewind_psw':
compel/arch/s390/src/lib/infect.c:157:29: error: 'UL' undeclared (first use in this function)
  157 |         mask = (psw->mask & PSW_MASK_EA) ? -1UL : (psw->mask & PSW_MASK_BA) ? (1UL << 31) - 1 : (1UL << 24) - 1;
      |                             ^~~~~~~~~~~
compel/arch/s390/src/lib/infect.c:157:29: note: each undeclared identifier is reported only once for each function it appears in
compel/arch/s390/src/lib/infect.c: In function 'get_ri_cb':
compel/arch/s390/src/lib/infect.c:272:25: error: 'UL' undeclared (first use in this function)
  272 |         if (psw->mask & PSW_MASK_RI)
      |                         ^~~~~~~~~~~
compel/arch/s390/src/lib/infect.c: In function 's390_disable_ri_bit':
compel/arch/s390/src/lib/infect.c:289:23: error: 'UL' undeclared (first use in this function)
  289 |         psw->mask &= ~PSW_MASK_RI;
      |                       ^~~~~~~~~~~
compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task':
compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function)
  523 |         if (psw->mask & PSW_MASK_RI) {
      |                         ^~~~~~~~~~~
Comment 5 Yaakov Selkowitz 2023-07-31 16:33:02 UTC 
This is also happening only with the 6.5~rc kernel-headers in rawhide; an F38 scratch build with 6.4 kernel-headers succeeds on s390x.
Comment 6 Dan Horák 2023-07-31 16:58:38 UTC 
likely caused by https://github.com/torvalds/linux/commit/b8af5999779d1225c82fcc960223625b279f5f0d
Comment 7 Adrian Reber 2023-07-31 17:15:44 UTC 
Right. Just also tracked it down to that commit. Thanks.
Comment 8 Yaakov Selkowitz 2023-07-31 17:17:07 UTC 
Agreed, and specifically it comes from the introduction of the use of `_AC` without #include <linux/const.h>
Comment 9 Adrian Reber 2023-07-31 17:20:24 UTC 
Created an upstream PR: https://github.com/checkpoint-restore/criu/pull/2232
Comment 10 Yaakov Selkowitz 2023-07-31 17:31:16 UTC 
Can we get the missing #include <linux/const.h> added to the kernel header itself?
Comment 11 Adrian Reber 2023-07-31 17:37:01 UTC 
I reached out to the original authors.
Comment 12 Adrian Reber 2023-08-01 10:20:45 UTC 
Builds again with the patch from Yaakov, thanks.
Note You need to log in before you can comment on or make changes to this bug.