Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 222598 (php-pecl-radius) - Review Request: php-pecl-radius - Radius client library
Summary: Review Request: php-pecl-radius - Radius client library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: php-pecl-radius
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2007-01-15 02:12 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-03-13 08:04:59 UTC
Type: ---
Embargoed:
fedora: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Stone 2007-01-15 02:12:30 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius-1.2.4-1.src.rpm

Description:
This package is based on the libradius of FreeBSD, with some modifications
and extensions.  This PECL provides full support for RADIUS authentication
(RFC 2865) and RADIUS accounting (RFC 2866), works on Unix and on Windows.
Its an easy way to authenticate your users against the user-database of your
OS (for example against Windows Active-Directory via IAS).
Comment 1 Matthias Saou 2007-02-13 18:49:25 UTC 
I wanted to take a quick look at this package, but it seems that
tkmame.retrogames.com is unavailable at the moment.
Comment 2 Christopher Stone 2007-02-13 20:45:07 UTC 
Unfortunately not the most reliable server.   Seems to be back up now.
Comment 3 Remi Collet 2007-03-10 15:45:00 UTC 
What about using the new provides to ensure ABI compatibility with PHP

For example
%if %{?php_zend_api}0
# for fedora >= 6
Requires:     php(zend-abi) = %{php_zend_api}
Requires:     php(api) = %{php_core_api}
%else
# for fedora <= 5
Requires:     php-api = %{php_apiver}
%endif
Comment 4 Remi Collet 2007-03-11 07:20:00 UTC 
As for php-pear packages, php-pecl tarball have a package.xml outside any
directory. So, you must use

%prep
%setup -c -q
cd radius-%{version}
Comment 5 Remi Collet 2007-03-11 13:52:46 UTC 
I finally succeed to install a local radius server and to have a working test
for this extension, so, 

=== REVIEW ===
:) source files match upstream:
3d48ccb9486b9e8839d814d7ff318091  radius-1.2.4.tgz
:) package meets naming and packaging guidelines.
:( specfile is properly named, is cleanly written and uses macros consistently.
=> see comment #4
:) dist tag is present.
:) build root is correct (second form).
:) license field matches the actual license.
:) license is open source-compatible (BSD).
:) latest version is being packaged (1.2.4)
:) BuildRequires are proper.
:) %clean is present.
:) package builds in mock (FC6).
:) package installs properly
:) rpmlint is silent.
:) final provides are sane:
config(php-pecl-radius) = 1.2.4-1.fc7
php-pecl(radius) = 1.2.4-1.fc7
radius.so()(64bit)  
php-pecl-radius = 1.2.4-1.fc7
:/ final Requires are sane:
=> see comment # 3
:) %check is not present; 
:) owns the directories it creates
:) no duplicates in %files.
:) file permissions are appropriate.
:) no scriplet
:) code, not content.
:) documentation is small, so no -docs subpackage is necessary.
:) %docs are not necessary for the proper functioning of the package.

Don't know if "release" is need in virtual provide 'php-pecl(radius)' ? 
perl and php-pear virtual provide never used it.

Should : comment #3
Must: comment #4
Comment 6 Christopher Stone 2007-03-11 21:29:02 UTC 
Indeed, my php-pecl-xdebug package will also need to be fixed.  Thanks for
spotting this.


Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pecl-radius-1.2.4-2.src.rpm

%changelog
* Sun Mar 11 2007 Christopher Stone <chris.stone> 1.2.4-2
- Use new ABI check for FC-6
- Create directory to untar sources
- Remove %%{release} from Provides
Comment 7 Remi Collet 2007-03-12 05:12:10 UTC 
Option -n to %setup is not needed... but not a issue.


== APPROVED ==
Comment 8 Christopher Stone 2007-03-12 18:46:22 UTC 
New Package CVS Request
=======================
Package Name: php-pecl-radius
Short Description: Radius client library
Owners: chris.stone
Branches: FC-5 FC6 devel
InitialCC:
Comment 9 Christopher Stone 2007-03-13 08:04:39 UTC 
- Fixed -n option
- Imported and built on FC-5 FC-6 and devel

Thanks for the review!

:D
Comment 10 Christopher Stone 2007-05-10 21:33:50 UTC 
Package Change Request
======================
Package Name: php-pecl-radius
New Branches: EL-5
Note You need to log in before you can comment on or make changes to this bug.